Saved tabs are not saved but forgotten
Categories
(Firefox :: Session Restore, defect)
Tracking
()
People
(Reporter: utlord, Unassigned, NeedInfo)
Details
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0
Steps to reproduce:
Close firefox with several tabs open (once over 50, recently less than 15), private window first, then the main FF window, then shut down computer
Actual results:
After the restart, a new session was opened and all my tabs were forgotten. This is the second time at least that this happened. It did only happen since 1 month or so. For years this was hardly a problem. Maybe this has to do with a quick but regular shutdown of the computer after FF was closed.
Win 7, FF 103
Expected results:
Show again the previous tabs of the last session (yes, the setting is enabled).
Also the option to restore the last x sessions would be helpful, maybe on the new-tab-screen.
With the help of Antonin Loubiere I found that the old tabs still existed under "Chronik --> recently closed windows". Restoring this restored all the tabs. Yet, why did it happen in the first place
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 3•3 years ago
|
||
(In reply to utlord from comment #1)
With the help of Antonin Loubiere I found that the old tabs still existed under "Chronik --> recently closed windows". Restoring this restored all the tabs. Yet, why did it happen in the first place
Did Firefox actually quit when you closed the second window? Or is it possible that you had a library window or other Firefox-process-window still open, and could that explain what had happened?
It did not quit, I closed the main window in a normal fashion after I closed the private one.
I never heard of a library window and hence don't think that such a thing was open.
|
|
||
Comment 5•3 years ago
|
||
(In reply to utlord from comment #4)
It did not quit, I closed the main window in a normal fashion after I closed the private one.
I meant, are you sure the browser processes finished shutting down before you shut down Windows?
I never heard of a library window and hence don't think that such a thing was open.
"show all bookmarks" or "show all downloads" open this window.
At this point I'm not sure how to debug this further, without being able to reproduce... Antonin, do you have further ideas?
It is well possible that Windows force-quit FF while shutting down. I have it very often that I have to restart FF because it doesnt load tabs (as if offline) and then it usually tells me that another FF instance is running.
|
||
Comment 7•3 years ago
|
||
Maybe we are wrongly setting or keeping the flag _maybeDontRestoreTabs which causes the window to be closed? I initially thought that if we open two window a private and a normal window, then if we close and restore the normal window it will be flagged and then I thought the flag might be restored (but I remember that we start a new window and then copy interesting data in the new window and so the flag isn't copied, right?, wasn't able to reproduce anyway).
Maybe we are calling globalOverlay.js#closeWindow(true, ...) somewhere witch set the flag?
I've searched but I found only BrowserCloseTabOrWindow() but this only applies to the non-Chrome windows (which, if I'm correct is not the case?) and some remove tabs function in tabbrowser.js witch is intended.
Maybe we are removing tabs (calling removeTabs) just before quitting?
Utlord could you confirm that you never exit Firefox by closing remaining tabs (for example via the shortcut Ctrl+W)? And do you use any extension (and if it's the case do they close tabs)?
I wasn't able to reproduce this issue too (though I didn't try long)
Yes, I never close the tabs on the main window.
Installed these extensions:
Adblock Plus
DownThemAll
Facebook Container
NoScript
OneTab (not using it's functionality)
ProxTube
|
|
||
Comment 9•3 years ago
|
||
The severity field is not set for this bug.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 10•3 years ago
|
||
I didn't manage to reproduce either this issue on windows 7 x64 using the latest versions Nightly 107.0a1 and Firefox 105.0.3.
Following the steps from Comment 0, I've tested with the addons mentioned in Comment 8 both enabled and disabled. All the previous tabs opened in the main Firefox window are restored properly while having the option "Open previous windows and tabs" enabled in about:preferences.
Description
•