1785811 - [wpt-sync] Sync PR 35514 - [beacon-api] Fix request headers

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35514 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35514
Details from upstream follow.

Ming-Ying Chung <[e-mail]> wrote:

[beacon-api] Fix request headers

1. As mentioned in https://crbug.com/1352366,
   • Set beacon request mode to kCors.
   • Set request_initiator to the last committed origin from the RFH of the beacon's host.
   • Set beacon request credentials mode to kSameOrigin.
   • Added some unit tests to cover the change
2. Updated c++ docs & mojom docs, and added unit tests that are missing from https://crrev.com/c/3826326

Bug: 1352366,1293679
Change-Id: Ic8b58d3d9f4aa9e1d47f4503fe65eda02d551e93

Reviewed-on: https://chromium-review.googlesource.com/3838589
WPT-Export-Revision: b7efbaba0d2a47bf713a219681cbc0a9b52bd45d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 35514 applied with additional changes from upstream: 74938560647321aed597aa158a4bff731edbd759, f1ef84ca14e9e7f18d82544dfa2191ccab027757, 132606abb6068abac3aad510ede995caa37032de

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6869ccbbc504703863edb7b5aeabb579d350517

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

ERROR: 8

Chrome

ERROR: 8

Safari

ERROR: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /pending_beacon/pending_beacon-basic.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-deactivate.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-sendnow.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-sendondiscard.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_get_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_get_beacon-send.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_post_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_post_beacon-sendwithdata.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7f46dad2bde
[wpt PR 35514] - [beacon-api] Fix request headers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/04cd0aa1ee26
[wpt PR 35514] - Update wpt metadata, a=testonly

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d7f46dad2bde
https://hg.mozilla.org/mozilla-central/rev/04cd0aa1ee26