1785825 - Allow adding ETP exceptions from about:preferences#privacy

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Emma Zühlcke [:emz]]

Currently it's only possible to remove sites via the "Exceptions for Enhanced Tracking Protection" dialog. Sometimes adding entries via the shield icon isn't possible, e.g. because of a short-lived redirect.

The cookies and site data exceptions dialog already has this functionality.

(This might be a dupe but I wanted to make sure it doesn't get lost)

Comment 1

[Hannah Peuckmann]

Attachment: Bug 1785825 - Add ETP exceptions from about:preferences#privacy. r=pbz!

Comment 2

[Meridel [:meridel]]

Can you please dig into this and make a recommendation? If it needs something larger than a string let me know and we can discuss. Thank you.

Comment 3

[pbothun]

Hi Hannah, I basically used the setup in Cookies and Site Data with a bit of content tweaking. Basically, the "new" ETP exceptions dialog would be a body field, a web address text entry field, and a CTA button, just like in Cookies and Site Data. Does this line up with what you were thinking?

I'll need to get additional sign off from our Content Team and Flod, but the not final strings are below. Am I off-base with what the expected UI is here, or am I missing something else? Thanks!

Body Text:
You can specify which websites have Enhanced Tracking Protection turned off. Type the exact address of the site you want to manage and then click Add Exception.

Text Entry field label:
Address of website
[Address block]

CTA Button:
Add Exception

Comment 4

[Hannah Peuckmann]

(In reply to pbothun from comment #3)

Hi Hannah, I basically used the setup in Cookies and Site Data with a bit of content tweaking. Basically, the "new" ETP exceptions dialog would be a body field, a web address text entry field, and a CTA button, just like in Cookies and Site Data. Does this line up with what you were thinking?

It does, thank you!

I'll need to get additional sign off from our Content Team and Flod, but the not final strings are below. Am I off-base with what the expected UI is here, or am I missing something else? Thanks!

Sounds good!

Comment 5

[Hannah Peuckmann]

Attachment: etp-exceptions-dialogue.png

Adding the strings, this is what it would look like.
Do you approve Phil?

Comment 6

[pbothun]

(In reply to hpeuckmann from comment #5)

Created attachment 9302675 [details]
etp-exceptions-dialogue.png

Adding the strings, this is what it would look like.
Do you approve Phil?

Yup! Looks good. This mirrors cookies and site data pretty well, so I'm good with these. Thanks for the screenshot!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f00c8ed7c6e4
Add ETP exceptions from about:preferences#privacy. r=fluent-reviewers,pbz,flod,settings-reviewers,hjones

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f00c8ed7c6e4