Closed Bug 1785868 Opened 2 years ago Closed 2 years ago

Remove extra space from below Tab Pickup when it is collapsed

Categories

(Firefox :: Firefox View, defect, P2)

defect

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox106 --- verified

People

(Reporter: sfoster, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

Attachments

(2 files, 1 obsolete file)

When you collapse the Tab Pickup section on Fx-View, there is too much vertical space between it and the Recently Closed section below.

From the dupe:

Adding grid-template-rows: masonry to the body > main grid layout fixes this.

Ah, I thought I had a memory of filing this, but didn't find it because it wasn't in the Firefox View component.

Component: General → Firefox View
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a064ed3c5dc
Allow items in the fx-view main column to move up into empty vertical space. r=Gijs
Blocks: 1788810
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Regressions: 1788921

I did file bug 1788810 to follow-up, but it probably makes more sense to just back this out.

Status: RESOLVED → REOPENED
Flags: needinfo?(sfoster)
Resolution: FIXED → ---
Target Milestone: 106 Branch → ---
Flags: needinfo?(sfoster)

I'm relinquishing this one for now. Ideally we'd fix this without having to re-implement the whole grid-based layout, and grid-template-rows: masonry was one such fix. But as that is nightly-only for now, we'll need a different solution.

Assignee: sfoster → nobody

The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates.
:sfoster, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)

I don't think we need to bump severity here. The symptom is some extra vertical space when the Tab Pickup section is collapsed - which is not something we expect most people to do.

Flags: needinfo?(sfoster)
Attachment #9292706 - Attachment is obsolete: true
Assignee: nobody → hjones
See Also: → 1789318

This is the same as using minmax(0, max-content). Using this for the first track seems to get the height to more accurately reflect the content and removes some of the extra whitespace/jumpiness on the page.

Attachment #9293780 - Attachment description: Bug 1785868 - Give tab pickup a more explicit height to remove vertical sapce r=gijs,sfoster → Bug 1785868 - Give tab pickup a more explicit height to remove vertical space r=gijs,sfoster
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/398f80782383
Give tab pickup a more explicit height to remove vertical space r=Gijs
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Flags: qe-verify+

Reproduced this issue using an old Nightly build 2022-08-18, verified that this is no longer reproducible on latest Firefox 106.0b2 across platforms (macOS 11, Windows 10, Ubuntu 20.04).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: