1785868 - Remove extra space from below Tab Pickup when it is collapsed

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: Screenshot from 2022-08-18 10-30-28.png

When you collapse the Tab Pickup section on Fx-View, there is too much vertical space between it and the Recently Closed section below.

Comment 2

[:Gijs (out for now; he/him)]

From the dupe:

Adding grid-template-rows: masonry to the body > main grid layout fixes this.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Ah, I thought I had a memory of filing this, but didn't find it because it wasn't in the Firefox View component.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1785868 - Allow items in the fx-view main column to move up into empty vertical space. r?Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a064ed3c5dc
Allow items in the fx-view main column to move up into empty vertical space. r=Gijs

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5a064ed3c5dc

Comment 7

[Sam Foster [:sfoster] (he/him)]

I did file bug 1788810 to follow-up, but it probably makes more sense to just back this out.

Comment 8

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8cfab3a930f43fe95cfefc62336cd7666253057c

Comment 10

[Marian-Vasile Laza]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/8cfab3a930f43fe95cfefc62336cd7666253057c

Comment 13

[Sam Foster [:sfoster] (he/him)]

I'm relinquishing this one for now. Ideally we'd fix this without having to re-implement the whole grid-based layout, and grid-template-rows: masonry was one such fix. But as that is nightly-only for now, we'll need a different solution.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates.
:sfoster, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 15

[Sam Foster [:sfoster] (he/him)]

I don't think we need to bump severity here. The symptom is some extra vertical space when the Tab Pickup section is collapsed - which is not something we expect most people to do.

Comment 16

[Hanna Jones [:hjones]]

Attachment: Bug 1785868 - Give tab pickup a more explicit height to remove vertical space r=gijs,sfoster

This is the same as using minmax(0, max-content). Using this for the first track seems to get the height to more accurately reflect the content and removes some of the extra whitespace/jumpiness on the page.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/398f80782383
Give tab pickup a more explicit height to remove vertical space r=Gijs

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/398f80782383

Comment 19

[Bogdan Maris, Desktop Test Engineering]

Reproduced this issue using an old Nightly build 2022-08-18, verified that this is no longer reproducible on latest Firefox 106.0b2 across platforms (macOS 11, Windows 10, Ubuntu 20.04).