1785871 - support base64url format for CSP hash sources

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Daniel Veditz [:dveditz]]

CSP level 3 has added support for hash sources in base64url format. In § 6.6.3.3. Does element match source list for type and source? step 5.2.5.2 says

Let expected be expression’s base64-value part, with all '-' characters replaced with '+', and all '_' characters replaced with '/'.

Note: This replacement normalizes hashes expressed in base64url encoding into base64 encoding for matching.

doing the character replacement could easily be done in the nsCPSHash constructor and everything after that should work just fine.

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1785871 - CSP: normalize base64url encoded sources into normal base64 r?ckerschb

Comment 2

[Frederik Braun [:freddy]]

Attachment: Bug 1785871 - test to wpt for base64url to base64 conversion r?ckerschb

Depends on D155218

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbb08887b03a
CSP: normalize base64url encoded sources into normal base64 r=ckerschb,tjr
https://hg.mozilla.org/integration/autoland/rev/eafc62485890
test to wpt for base64url to base64 conversion r=ckerschb

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35601 for changes under testing/web-platform/tests

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bbb08887b03a
https://hg.mozilla.org/mozilla-central/rev/eafc62485890

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot