178590 - fix compiler warning in string/public/nsBufferHandleUtils.h

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

This is just a little patch that fixes a minor compiler warning in
string/public/nsBufferHandleUtils.h -- line 71 has an assignment inside an if().

Comment 1

[Benjamin Smedberg]

Attachment: -u patch

-u patch

Comment 2

[jag (Peter Annema)]

Which compiler?

I thought compilers would warn for

  if ( foo = bar )

but not for

  if ( (foo = bar) )

Regardless, there is nothing wrong with an assigment inside an if, it's nice
that the compiler tries to tell us we may have meant == instead of =, but I
don't think we need to make this change just to make some compiler not warn.

Comment 3

[Benjamin Smedberg]

Compiler is MSVC6 (warning-level 4)

I normally don't care about warnings in mozilla source files, but this is a
header that I was including (through nsASharableString) in another application,
and getting warnings on each source file that included it.

Truly it doesn't make a big difference, but the change can't hurt, can it?  I
thought that providing a patch might make it a painless fix ;)

Comment 4

[jag (Peter Annema)]

Alec, dbaron, what do you two think?

It's a shame MSVC6 doesn't take the parentheses hint that this was really what
we meant and not a typo.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Making the change is ok with me.  Just wait to check it in until something else
comes around that triggers a world-rebuild.

Comment 6

[Alec Flett]

Comment on attachment 105288 [details] [diff] [review]
-u patch

sounds fine to me too. sr=alecf

Comment 7

[Benjamin Smedberg]

Reopening per comments.  This is obviously not urgent, so it could wait even
until the 1.4 tree opening if need be.

Comment 8

[jag (Peter Annema)]

Comment on attachment 105288 [details] [diff] [review]
-u patch

r=jag

Comment 9

[Benjamin Smedberg]

Mine, this will go in after 1.4

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 105288 [details] [diff] [review]
-u patch


bsmedberg (or anyone):
Can you check in your r+/sr+ patch ? Thanks.

Comment 11

[Serge Gautherie (:sgautherie)]

Retargeting: v1.5a -> v1.7a.

Comment 12

[Benjamin Smedberg]

This code has disappeared ;)