Closed Bug 1786055 Opened 4 months ago Closed 3 months ago

Migrate editMenuOverlay.dtd to Fluent

Categories

(Firefox :: Bookmarks & History, task)

task

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: eemeli, Assigned: eemeli)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The editMenuOverlay.dtd file is one of the few remaining DTD files used for localization, and should be migrated to Fluent. Its strings are used in a few different places: https://searchfox.org/mozilla-central/search?q=editMenuOverlay.dtd

Blocks: 1786543

editMenuOverlay.dtd defines a few keyboard shortcuts for find & find-again commands. One of the two places where they're used is editMenuKeys.inc.xhtml, which itself is used from the sidebar, places & the content-area downloads view.

But I don't think those key definitions actually do anything? At least on macOS, I can't find anything working differently if I just remove those lines (last touched in 2003), and no relevant try auto tests appear to break.

Neil, :mconley suggested that you might have some idea regarding my question above?

For a bit more context, according to my manual testing on macOS:

  • these key shortcuts are not actually handled by the history & bookmarks sidebars, so pressing Cmd+F there will open the page's own find bar instead
  • while in the Library dialog, Cmd+F will focus the "Search Bookmarks" field whether or not editMenuKeys.inc.xhtml includes <key> definitions
  • the about:downloads view does not actually have any find/filter functionality

Furthermore, rather similar <key> definitions are also included in browser-sets.inc.

Flags: needinfo?(enndeakin)

It doesn't look like these are used, so I think we can try removing them.

Flags: needinfo?(enndeakin)

It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.

After the preceding change, the editMenuOverlay strings are only used by the styleeditor.
Therefore it makes sense to migrate them here specifically to its localization file.

Depends on D155448

Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fa8c82df205
Drop find keys from editMenuKeys.inc.xhtml. r=mconley
https://hg.mozilla.org/integration/autoland/rev/227dfbdf295a
Migrate styleeditor DTD localization to Fluent. r=nchevobbe,fluent-reviewers,flod
See Also: → 1787591
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.