Migrate editMenuOverlay.dtd to Fluent
Categories
(Firefox :: Bookmarks & History, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: eemeli, Assigned: eemeli)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The editMenuOverlay.dtd file is one of the few remaining DTD files used for localization, and should be migrated to Fluent. Its strings are used in a few different places: https://searchfox.org/mozilla-central/search?q=editMenuOverlay.dtd
|
Assignee | |
Comment 1•2 years ago
|
||
editMenuOverlay.dtd defines a few keyboard shortcuts for find & find-again commands. One of the two places where they're used is editMenuKeys.inc.xhtml, which itself is used from the sidebar, places & the content-area downloads view.
But I don't think those key definitions actually do anything? At least on macOS, I can't find anything working differently if I just remove those lines (last touched in 2003), and no relevant try auto tests appear to break.
|
|
Assignee | |
Comment 2•2 years ago
•
|
||
Neil, :mconley suggested that you might have some idea regarding my question above?
For a bit more context, according to my manual testing on macOS:
- these key shortcuts are not actually handled by the history & bookmarks sidebars, so pressing Cmd+F there will open the page's own find bar instead
- while in the Library dialog, Cmd+F will focus the "Search Bookmarks" field whether or not
editMenuKeys.inc.xhtmlincludes<key>definitions - the
about:downloadsview does not actually have any find/filter functionality
Furthermore, rather similar <key> definitions are also included in browser-sets.inc.
|
||
Comment 3•2 years ago
|
||
It doesn't look like these are used, so I think we can try removing them.
|
|
Assignee | |
Comment 4•2 years ago
|
||
It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.
|
|
Assignee | |
Comment 5•2 years ago
|
||
After the preceding change, the editMenuOverlay strings are only used by the styleeditor.
Therefore it makes sense to migrate them here specifically to its localization file.
Depends on D155448
Pushed by earo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fa8c82df205 Drop find keys from editMenuKeys.inc.xhtml. r=mconley https://hg.mozilla.org/integration/autoland/rev/227dfbdf295a Migrate styleeditor DTD localization to Fluent. r=nchevobbe,fluent-reviewers,flod
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9fa8c82df205
https://hg.mozilla.org/mozilla-central/rev/227dfbdf295a
|
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
Description
•