1786086 - Miscellaneous layout-table-status caching issues

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

While working on bug 1726124, I noticed a few issues with our existing layout-table-status caching implementation. I'll fix them here as follow-up:

1. When we queue a CacheDomain::Table cache update from DocAccessible::PruneOrInsertSubtree, we dispatch the update on the accessible that the function was called with. This could be a table or a table part. If it is a table part, when the CacheDomain::Table update is bundled, we won't update the layout table status (that only occurs on tables). We should dispatch this on the table instead.
2. We do not currently queue an update for CacheDomain::Table from nsAccessibilityService::TableLayoutGuessMaybeChanged. We should queue an update any time we fire the EVENT_TABLE_STYLING_CHANGED.
3. When a border changes on a table, it can affect the layout table status. Right now, we check for this style change in nsTableCellFrame, but the border the original code references is not stored in the cell's ComputedStyle(). Instead, borders set by <table border=1"> are stored on the table frame (or maybe table wrapper frame? still TBD, discussing on matrix). We should relocate this code to nsTableFrame::DidSetComputedStyle.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1786086: [Part 1] Add test to verify changing border style changes layout status r?Jamie

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1786086: [Part 2] Queue table cache update when TableLayoutGuessMaybeChanged is called r?Jamie

Depends on D155131

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1786086: [Part 3] Queue table cache update on table acc in PruneOrInsertSubtree r?Jamie

Depends on D155132

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1786086: [Part 4] Watch for border style changes in nsTableFrame instead of nsTableCellFrame r?Jamie

Depends on D155133

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25a5c81eded3
[Part 1] Add test to verify changing border style changes layout status r=Jamie
https://hg.mozilla.org/integration/autoland/rev/76dd155c66b8
[Part 2] Queue table cache update when TableLayoutGuessMaybeChanged is called r=Jamie
https://hg.mozilla.org/integration/autoland/rev/169c9576cb7b
[Part 3] Queue table cache update on table acc in PruneOrInsertSubtree r=Jamie

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for failures on browser_table.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=169c9576cb7b9bcb9412ca75ba95289f8e7983ac&selectedTaskRun=QvgUHAJOQQ6tsel_nrls_g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=388801346&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/dfe1912f7a46889d7bfa088b8c2d3fa59930f8f0

Comment 7

[Morgan Reschenberg [:morgan]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8bd026ad7cd171028fb0d6a1571e00b85344de3b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c22a758e0e
[Part 1] Add test to verify changing border style changes layout status r=Jamie
https://hg.mozilla.org/integration/autoland/rev/3dd58ffe278d
[Part 2] Queue table cache update when TableLayoutGuessMaybeChanged is called r=Jamie
https://hg.mozilla.org/integration/autoland/rev/204e5f0247ee
[Part 3] Queue table cache update on table acc in PruneOrInsertSubtree r=Jamie

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e7c22a758e0e
https://hg.mozilla.org/mozilla-central/rev/3dd58ffe278d
https://hg.mozilla.org/mozilla-central/rev/204e5f0247ee