Closed Bug 1786350 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35554 - Do not DCHECK on frame in requestStorageAccess

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox106 fixed)

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35554 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35554
Details from upstream follow.

Matt Reichhoff <mreichhoff@chromium.org> wrote:

Do not DCHECK on frame in requestStorageAccess

The spec indicates such calls should be rejected with a SecurityError. A
future commit will switch the promise return types; for now following
the reject with undefined pattern used elsewhere in
requestStorageAccess.

Bug: 1354256
Change-Id: I65099ae4289f643021f4e2267189026e358f0b21
Reviewed-on: https://chromium-review.googlesource.com/3845652
WPT-Export-Revision: 2c3fae8c1fd08dfc1287a42378c6d06efabd73cb

PR 35554 applied with additional changes from upstream: 595d0a137c2a151231952fe5678fa362c3c80892

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 5 subtests

Status Summary

Firefox

OK : 2
PASS : 27
FAIL : 3
TIMEOUT: 2
NOTRUN : 2

Chrome

OK : 2
PASS : 2
FAIL : 18
ERROR : 1

Safari

OK : 3
PASS : 22
FAIL : 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /storage-access-api/requestStorageAccess.sub.window.html [wpt.fyi]: TIMEOUT (Chrome: ERROR, Safari: OK)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached frame: TIMEOUT (Safari: FAIL)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached DOMParser document: NOTRUN (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should be resolved when called properly with a user gesture: NOTRUN (Safari: FAIL)
  • /storage-access-api/storageAccess.testdriver.sub.html [wpt.fyi]
    • Set up storage access rules: FAIL (Chrome: FAIL, Safari: FAIL)
    • [third-party-blocked-all] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)
    • [third-party-blocked-on-first-party-site] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65e96c897d00 [wpt PR 35554] - Handle detached frames in requestStorageAccess(), a=testonly https://hg.mozilla.org/integration/autoland/rev/9fb0f00dee79 [wpt PR 35554] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/65e96c897d00
https://hg.mozilla.org/mozilla-central/rev/9fb0f00dee79

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.