1786353 - Excessive Table Cell Size With `vertical-align: baseline` in Vertical Writing Mode

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[David Shin[:dshin]]

Attachment: Mimimum Reproducible Case

STR: Load the attached test case.
Expected Behaviour: Table cells should be sized to that of the inner div's.
Actual Behaviour: The cells are twice as wide as the inner divs.

Goes away if vertical-align is unset or writing-mode: horizontal-tb.

Looks to be caused by this code here that does not consider the logical size.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1786353 - Use logical sides when calculating table cell baseline. r=#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15df26cfaf48
Use logical sides when calculating table cell baseline. r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35580 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/15df26cfaf48

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue using the testcase from the Description on Firefox 105.0.3(build ID: 20221007134813) on macOS 12. Verified as fixed on Firefox 106.0(build ID: 20221010110315) and Nightly 107.0a1(build ID: 20221012094509) on macOS 12, Windows 10, Ubuntu 22.