Apply the delay crashing on OOM idea to the JS GC.
Categories
(Core :: JavaScript: GC, enhancement, P2)
Tracking
()
People
(Reporter: pbone, Unassigned)
References
(Blocks 2 open bugs)
Details
In Bug 1716727 gsvelto and rkraesig implemented a delay before crashing from OOM to give windows a chance to find more virtual memory. This seems to be working and since there are VIrtualAlloc calls in JSGC we should probably do the same there.
Alternatively some time ago glandium suggested that we consolidate our calls to VirtualAlloc, especially where we cache memory blocks since JSGC and jemalloc have some similar requirements for these blocks.
|
||
Comment 1•2 years ago
|
||
More discussion on this topic is happening in bug 1784033 where we proposed to hook VirtualAlloc() (but it might not be a good idea).
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
(In reply to Paul Bone [:pbone] [PTO until 8/8/22] from comment #0)
Looks like this is very effective at moving crashes from the parent process to content process, but doesn't necessarily reduce the number of overall crashes.
Nevertheless, content process crashes are a better user experience so we should consider doing this.
Description
•