1786452 - Overscroll effect not gone on Android 12+ if finger is released

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Makoto Kato [:m_kato]]

This is moved from bug 1710708.

Android 12+ uses stretch animation for overscroll animation, instead of glow drawing. But when using stretch animation, animation isn't sometimes finished. So Overscroll effect is kept even if user release finger on screen.

The APZ call sequences are the following

1. AndroidContentController::UpdateOverscrollOffset
2. AndroidContentController::UpdateOverscrollVelocity

UpdateOverscrollVelocity calls EdgeEffect.onRelease in OverscrollEdgeEffect.setVelocity, So animation is finished.

But when this occurs, the APZ call sequences are the following

1. AndroidContentController::UpdateOverscrollOffset
2. AndroidContentController::UpdateOverscrollVelocity
3. AndroidContentController::UpdateOverscrollOffset
   ... (repeat 3. since we keep finger on screen)
   n. AndroidContentController::UpdateOverscrollOffset.

So since UpdateOverscrollOffset doesn't call EdgeEffect.onRelease, animation isn't finished. When using glow drawing, I am not sure that EdgeEffect seems to finish animation even if not calling EdgeEffect.onRelease...

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=ad65feba6e344c1024cb878dbd2b4ea70519597f

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1786452 - Finish overscroll animation when finishing pan. r=m_kato

GeckoView's overscroll is implemented by OS side using
WidgetOverscrollEffect.

When not releasing finger during overscroll, stretched animation is kept on
Android 12+ since EdgeEffect.onRelease isn't called. Then, when releasing
finger, this animation isn't finished on GeckoView with Android 12+.

When this situation, APZ doesn't call
WidgetOverscrollEffect::HandleFlingOverscroll by releasing finger due to too
small velocity value in AsyncPanZoomController::HandleEndOfPan. So there is
no way to detect whether releasing finger on GeckoView side.

I think We should notify GeckoView of releasing finger to finish animation.

This won't occurs on GenericOverscollEffect on macOS since overscoll
animation is managed by APZ and this animation will be finished by
UpdateAnimation.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1786452 - Add a gtest. r=m_kato

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1786452 - Rename OverscrollEffectBase::HandleFlingOverscroll() to RelieveOverscroll(). r=hiro

The function is used in some scenarios unrelated to fling animation.

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1786452 - Implement IsOverscrolled() for WidgetOverscrollEffect. r=hiro

A couple of call sites, which are only interested in overscrolling that
induces a transform, are changed to call IsPhysicallyOverscrolled(),
the GenericOverscrollEffect implementation, directly.

Depends on D157004

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1786452 - Implement ClearOverscroll() for WidgetOverscrollEffect. r=hiro

Depends on D157005

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9918193202b5
Rename OverscrollEffectBase::HandleFlingOverscroll() to RelieveOverscroll(). r=hiro
https://hg.mozilla.org/integration/autoland/rev/d76ddc2e3c58
Implement IsOverscrolled() for WidgetOverscrollEffect. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6f111e745189
Implement ClearOverscroll() for WidgetOverscrollEffect. r=hiro
https://hg.mozilla.org/integration/autoland/rev/b584463ec5b6
Finish overscroll animation when finishing pan. r=geckoview-reviewers,owlish,m_kato
https://hg.mozilla.org/integration/autoland/rev/0bdbe3eb11f6
Add a gtest. r=hiro

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/9918193202b5
https://hg.mozilla.org/mozilla-central/rev/d76ddc2e3c58
https://hg.mozilla.org/mozilla-central/rev/6f111e745189
https://hg.mozilla.org/mozilla-central/rev/b584463ec5b6
https://hg.mozilla.org/mozilla-central/rev/0bdbe3eb11f6