1786455 - Perma [tier 2] Assertion failure: !UpdateResponsiveSource() (The image source should be the same because we update the responsive source synchronously), at /builds/worker/checkouts/gecko/dom/html/HTMLImageElement.cpp:890

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=388157903&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TXHJIcGJTuygQn_kxUzfUA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-08-23T03:24:15.708Z] 03:24:15     INFO - TEST-OK | layout/style/test/test_bug418986-2.html | took 183ms
[task 2022-08-23T03:24:15.718Z] 03:24:15     INFO - GECKO(3931) | [Parent 3931, Main Thread] WARNING: Received `load` event on unbridged BrowserParent!: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3996
[task 2022-08-23T03:24:15.718Z] 03:24:15     INFO - GECKO(3931) | [Parent 3931, Main Thread] WARNING: Received `load` event on unbridged BrowserParent!: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3996
[task 2022-08-23T03:24:15.719Z] 03:24:15     INFO - GECKO(3931) | Assertion failure: !UpdateResponsiveSource() (The image source should be the same because we update the responsive source synchronously), at /builds/worker/checkouts/gecko/dom/html/HTMLImageElement.cpp:890
[task 2022-08-23T03:24:15.724Z] 03:24:15     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2022-08-23T03:24:21.868Z] 03:24:21     INFO - GECKO(3931) | #01: mozilla::dom::HTMLImageElement::LoadSelectedImage(bool, bool, bool) [dom/html/HTMLImageElement.cpp:888]
[task 2022-08-23T03:24:21.869Z] 03:24:21     INFO - GECKO(3931) | #02: mozilla::dom::ImageLoadTask::Run(mozilla::AutoSlowOperation&) [dom/html/HTMLImageElement.cpp:101]
[task 2022-08-23T03:24:21.869Z] 03:24:21     INFO - GECKO(3931) | #03: mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint(bool) [xpcom/base/CycleCollectedJSContext.cpp:677]
[task 2022-08-23T03:24:21.870Z] 03:24:21     INFO - GECKO(3931) | #04: nsGlobalWindowInner::CallDocumentFlushedResolvers(bool) [dom/base/nsGlobalWindowInner.cpp:7325]
[task 2022-08-23T03:24:21.871Z] 03:24:21     INFO - GECKO(3931) | #05: nsGlobalWindowInner::FreeInnerObjects() [dom/base/nsGlobalWindowInner.cpp:1234]
[task 2022-08-23T03:24:21.871Z] 03:24:21     INFO - TEST-START | layout/style/test/test_bug437915.html

Comment 1

[Marian-Vasile Laza]

Hi Boris, can you please take a look? thanks :)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1694741

Comment 3

[Tyson Smith [:tsmith]]

This is being hit frequently by the DOM fuzzers.

Comment 4

[Boris Chiou [:boris]]

I tries to reproduce this assertion by
./mach mochitest layout/style/test/test_bug418986-2.html --enable-xorigin-tests --run-until-failure

And looks like we hit the assertion because we are still running the load image task after calling DestroyContent() (i.e. after finishing the test).

Perhaps a simple way is to add one extra condition to check if the content is destroyed.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1786455 - Clear the pending image load task after we destroy the image element.

It seems UpdateResponsiveSource() may return an unexpected result after
we call HTMLImageElement::ContentDestroy(), which nullifies
mResponsiveSelector. So we have to tweak the assertion condition.

We can reproduce this by running layout/style/test/test_bug418986-2.html
with xorigin, if we don't apply this patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1c5e3749ee4
Clear the pending image load task after we destroy the image element. r=emilio

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d1c5e3749ee4

Comment 8

[Intermittent Failures Robot]

8 failures in 3293 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6
• autoland: 2

Platform and build breakdown:

• macosx1015-64-qr: 8
  • debug: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1786455&startday=2022-08-22&endday=2022-08-28&tree=all