1786501 - Shutdown StorageManager when nsIGlobalObject is dying

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

StorageManager will hold FileSystemManager which will hold FileSystemManagerChild. PFileSystemManager is a top level protocol which needs to be properly closed when IPC is still available.

The new lifecycle management (bug 1786465) can actually cause that the protocol is closed during cycle collection (when there are no DOM objects referencing FileSystemManager).

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Add empty StorageManager::Shutdown method; r=#dom-storage

Depends on D155368

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Call StorageManager::Shutdown from Navigator::Invalidate; r=#dom-storage,smaug

Depends on D155369

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Implement WorkerNavigator::Invalidate; r=#dom-storage,asuth

Depends on D155370

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Call StorageManager::Shutdown from WorkerNavigator::Invalidate; r=#dom-storage,asuth

Depends on D155371

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Add a way to delete imported global properties; r=#dom-storage,smaug

Depends on D155372

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Add support for the "storage" property to xpc::GlobalProperties::Delete; r=#dom-storage,smaug

Depends on D155373

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Expose StorageManager::Shutdown to chrome; r=#dom-storage,smaug

This can be used for explicit testing of shutdown in tests.

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1786501 - Shutdown StorageManager when the test is done in _execute_test; r=#dom-storage,smaug

Depends on D155374

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cc6ef98fb61
Add empty StorageManager::Shutdown method; r=smaug
https://hg.mozilla.org/integration/autoland/rev/0986cb52d5b4
Call StorageManager::Shutdown from Navigator::Invalidate; r=smaug
https://hg.mozilla.org/integration/autoland/rev/49f18f0254ec
Implement WorkerNavigator::Invalidate; r=smaug
https://hg.mozilla.org/integration/autoland/rev/006bf330762f
Call StorageManager::Shutdown from WorkerNavigator::Invalidate; r=smaug
https://hg.mozilla.org/integration/autoland/rev/605ea704ca38
Expose StorageManager::Shutdown to chrome; r=smaug
https://hg.mozilla.org/integration/autoland/rev/1e92d61873a8
Shutdown StorageManager when the test is done in _execute_test; r=smaug

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9cc6ef98fb61
https://hg.mozilla.org/mozilla-central/rev/0986cb52d5b4
https://hg.mozilla.org/mozilla-central/rev/49f18f0254ec
https://hg.mozilla.org/mozilla-central/rev/006bf330762f
https://hg.mozilla.org/mozilla-central/rev/605ea704ca38
https://hg.mozilla.org/mozilla-central/rev/1e92d61873a8