1786612 - New Tab Telemetry Phase 2: Instrumentation Implementation

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

This bug's about implementing the instrumentation described in the doc: https://docs.google.com/document/d/1hbDTpXJd1n-0TrycGlQKTIpj0_yj9XUEgw7kIhRvBpE/edit#heading=h.5ergx5s48ew4

This more or less boils down to adding some Pocket instrumentation: impressions and clicks and settings (oh my). These are broadly already instrumented in activity stream pings (see also here). But this time they'll be in the "newtab" ping as standard Glean events.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1786612 - Add topsites and top stories prefs to 'newtab' ping r?nanj!

Also include pocket logged in status, which (because it's not a pref) is
sampled over time.

I'm not 100% confident I'm successfully encoding all the different ways newtab
and home can be configured. enabled/disabled/extension/<category>... where does
"blank" fit in? Do I need a special case for that?
Maybe we should go back to the start and make this just
"is {newtab|home} configured to show a newtab"?
I think that might be all we need.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1786612 - Instrument Pocket interactions with events r?nanj!

Depends on D155755

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1786612 - Also send 'newtab' pings at component init r?nanj!

Depends on D155756

Comment 4

[Chris H-C :chutten]

Attachment: data collection review request

Comment 5

[Megan McCorquodale]

Comment on attachment 9293512 [details]
data collection review request

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, this will be documented in the probe dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, users can opt out of telemetry collection.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Not permanent data collection.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, Interaction Data.

5. Is the data collection request for default-on or default-off?
   Default on.

6. Does the instrumentation include the addition of any new identifiers?
   No new identifiers.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does the data collection use a third-party collection tool?
   No.

---

data-review +

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7a5208065b3
Add topsites and top stories prefs to 'newtab' ping r=nanj,thecount
https://hg.mozilla.org/integration/autoland/rev/452406d34dc5
Instrument Pocket interactions with events r=thecount
https://hg.mozilla.org/integration/autoland/rev/412d47d01e7f
Also send 'newtab' pings at component init r=nanj

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/b7a5208065b3
https://hg.mozilla.org/mozilla-central/rev/452406d34dc5
https://hg.mozilla.org/mozilla-central/rev/412d47d01e7f