Closed Bug 1786634 Opened 2 years ago Closed 2 years ago

Check if ImageMask.repeat is always unused in Gecko and remove the unused feature

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: ahale, Assigned: ahale)

References

Details

Attachments

(1 file)

The only place in Gecko that produces an ImageMask struct for WebRender always sets repeat to false.

https://searchfox.org/mozilla-central/rev/d01591796d5faccf762adb09a311d8ee12f7ca7f/gfx/layers/wr/WebRenderCommandBuilder.cpp#2853

If we can confirm this feature is never used, we should remove the code for it, which will make implementing Filter::Mask simpler ( https://bugzilla.mozilla.org/show_bug.cgi?id=1784383 ).

A basic run of Firefox Dev doesn't seem to present any problems with removing this field and corresponding code.

Pushed by ahale@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff1b771da350 Remove ImageMask.repeat field because it is always false r=gw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: