Closed Bug 1786708 Opened 2 years ago Closed 2 years ago

Migrate Form Autofill management dialogs to Fluent

Categories

(Toolkit :: Form Autofill, task)

task

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: eemeli, Assigned: eemeli)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

These are some of the few remaining users of DTD strings for localization, and should be migrated to Fluent.

The changes to FormAutofillPreferences depend on bug 1446164, so it makes more sense to specify this to migrating only the management dialogs and track the preferences changes separately.

Summary: Migrate Form Autofill management/preferences to Fluent → Migrate Form Autofill management dialogs to Fluent
Blocks: 1786788

Rather than using a custom wrapper around .properties strings,
the manageAddresses and manageCreditCards dialogs are here migrated to Fluent.

A new FTL file for the extension is added under browser/preferences/
rather than browser/extensions/formautofill/, as the former is a more common
location for FTL localizations, and the extension already relies on an FTL file
hosted outside its own directory, toolkit/payments/payments.ftl.

Attachment #9291364 - Attachment description: WIP: Bug 1786708 - Migrate formautofill management dialogs to Fluent → Bug 1786708 - Migrate formautofill management dialogs to Fluent. r=sgalich!
Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d298c6f7475
Migrate formautofill management dialogs to Fluent. r=sgalich,fluent-reviewers,preferences-reviewers,flod,jaws

Backed out for causing multiple failures

Backout link

Push with failures

Failure log 1

There's also this gv-junit failure . Here's the failure log for it (this failure line too).

Flags: needinfo?(earo)

Issue was caused by the edit-dialog fixes that were in the same stack; more details on bug 1446164.

Flags: needinfo?(earo)
Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f17923d28c10
Migrate formautofill management dialogs to Fluent. r=sgalich,fluent-reviewers,preferences-reviewers,flod,jaws
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: