1786828 - The "Get Firefox Focus" modal is no longer dismissed when the "x" button is clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Alice Varro [avarro], Ecosystem QA]

Attachment: x button not working on mobile modal pbm.gif

[Affected versions]:

• Firefox Nightly 106.0a1 - Build ID: 20220823214727
• Firefox Beta 105.0b2 - Build ID: 20220823185840

[Affected Platforms]:

• Windows 10 x64
• macOS 12.3.1
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the new Firefox profile opened.

[Steps to reproduce]:

1. Open a new private window and click the “Download Firefox Focus” button.
2. Click the “x” button from the “Get Firefox Focus” modal.

[Expected result]:

• The Close button from the “Get Firefox Focus” modal is actionable and the modal is dismissed.

[Actual result]:

• The Close button from the “Get Firefox Focus” modal is not actionable and the modal is not dismissed.

[Regression window]:

• The issue is not reproducible with older Nightly 104.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
  Last good revision: 43c1a6141f9ddb20447c6e5075612f59405cd9fb
  First bad revision: 32f983ac16be4e76e049a2a3c98e8035433727d9
  Pushlog: link

From this pushlog it seems that Bug 1758506 may have introduced this behavior.

[Notes]:

• The “Get Firefox Focus” modal can be dismissed by pressing the “Esc” key.
• The issue is not reproducible with keyboard navigation, in this case the modal is successfully dismissed.
• Attached is a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

I believe regressed by bug 1758506 changing from a background to a <picture>

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1758506

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1786828 - Remove pointer-events from spotlight picture element to keep it from overlapping the close button

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32b041108c7d
Remove pointer-events from spotlight picture element to keep it from overlapping the close button r=mviar

Comment 5

[Emily McMinn :emcminn]

Comment on attachment 9291402 [details]
Bug 1786828 - Remove pointer-events from spotlight picture element to keep it from overlapping the close button

Beta/Release Uplift Approval Request

• User impact if declined: Users will not be able to close the Firefox Focus modal once it has been opened, preventing interaction with the rest of the private browsing newtab page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS change removing pointer events from a non-interactable element
• String changes made/needed: none
• Is Android affected?: Yes

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/32b041108c7d

Comment 7

[Alice Varro [avarro], Ecosystem QA]

I have verified that this issue is no longer reproducible on Firefox Nightly 106.0a1 (Build ID: 20220825222149) on Windows 10x64, macOS 12.3.1 and Linux Mint 20.2 x64.

• The “Firefox Focus” modal is dismissed when the “x” button is clicked.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9291402 [details]
Bug 1786828 - Remove pointer-events from spotlight picture element to keep it from overlapping the close button

Approved for 105.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3c971305aaac

Comment 10

[Alice Varro [avarro], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 105.0b4 (Build ID: 20220828190315) on Windows 10x64, macOS 12.3.1 and Linux Mint 20.2 x64.