1786885 - Remove OS.Constants.{libc,win,sys}.*

Status: RESOLVED FIXED

(Toolkit :: IOUtils and PathUtils, task, P2)

Description

[Beth Rennie [:beth] (she/her)]

We are eventually removing osfile.jsm, which means you won't be able to get OS.Constants imported by importing a JSM.

The current way to define OS.Constants in a namespace is by doing:

  Cc["@mozilla.org/net/osfileconstantsservice;1"]
    .getService(Ci.nsIOSFileConstantsService)
    .init();

This grabs the current JS global and defines an OS object onto it. This seems magical and may lead to confusion. It might be better if we have something like:

  const {OS} = Cc["@mozilla.org/net/osfileconstantsservice;1"]
    .getService(Ci.nsIOSFileConstantsService)
    .init();

// or

const {OS} = Services.osConstants.init();

or maybe better still, have it available on Services directly

Services.osConstants.libc.O_CREAT

Comment 1

[Beth Rennie [:beth] (she/her)]

This is also likely busted on ESMs since it is grabbing the this member which doesn't exist in ESMs.

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1786885 - Remove usage of OS.Constants.* r?gijs

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1786885 - Remove OS.Constants r?nika

Depends on D179383

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1786885 - Add ChromeUtils::GetLibcConstants r?nika

ChromeUtils::GetPlatformConstants() is a replacement for
nsIOSFileConstantsService providing OS.Consts.LIBC and OS.Consts.Win.

Comment 5

[Mark Banner (:standard8)]

I believe all the OS.* modules have been removed now, so I don't think this blocks esm-ification.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/714fb5e0c999
Add ChromeUtils::GetLibcConstants r=nika

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bustages in ChromeUtils.webidl.

• Backout link
• Push with failures
• Failure Log
• Failure line: WebIDL.WebIDLError: error: invalid syntax, /builds/worker/workspace/obj-build/dom/bindings/ChromeUtils.webidl line 1050:17

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/910d59989abb
Add ChromeUtils::GetLibcConstants r=nika

Comment 9

[Iulian Moraru]

Backed out for causing multiple failures.
This affected only bc and xpcshell jobs on windows.

• Push with failures

• Failure log for failures on marSuccessPartialWhileBackgroundTaskRunning.js

• Failure log for failures on test_process_kill.js

• Failure log for failures on test_backgroundtask_deletes_profile.js

• Failure log for failures on test_native_manifests.js

• Failure log for failures on test_ext_native_messaging_perf.js

• Failure log for failures on updateSyncManager.js

• Failure log for failures on browser_backgroundtask_specific_pref.js

• Backout link

LATER EDIT: this is also affecting dt jobs:

• failed on browser_dbg-backgroundtask-debugging.js
• failed on browser_toolbox_styleeditor.js
• failed on browser_browser_toolbox.js
• failed on browser_storage_indexeddb_hide_internal_dbs.js

and this talos job damp-other that failed on browser-toolbox.js.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d135b3bcfd8
Add ChromeUtils::GetLibcConstants r=nika

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb52be0fcde
Remove OS.Constants r=nika

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4d135b3bcfd8

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0bb52be0fcde