1786982 - Intermittent \testing/web-platform/tests\html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html | single tracking bug

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1786982

Comment 3

[Natalia Csoregi [:nataliaCs]]

All failures here look related to Bug 1595491.

Failure log example: https://treeherder.mozilla.org/logviewer?job_id=388402692&repo=mozilla-central&lineNumber=4461

[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - TEST-PASS | /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio.html | Loaded picture test: Both <source> and <img> are with width and height attributes 
[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - TEST-UNEXPECTED-FAIL | /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html | Video width and height attributes are not used to infer aspect-ratio - assert_approx_equals: expected 1 +/- 0.001 but got 2.5
[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - assert_ratio@http://web-platform.test:8000/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:20:23
[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - video.onloadeddata<@http://web-platform.test:8000/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:46:17
[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-08-24T22:20:40.680Z] 22:20:40     INFO - Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:2665:32
[task 2022-08-24T22:20:40.785Z] 22:20:40     INFO - TEST-OK | /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html | took 823ms

:sefeng, can you take a look please?
Thank you.

Comment 4

[Intermittent Failures Robot]

47 failures in 3293 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #16 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 32
• mozilla-central: 15

Platform and build breakdown:

• android-em-7-0-x86_64-lite-qr: 8
  • opt: 8
• android-em-7-0-x86_64-qr: 37
  • debug: 32
  • opt: 5
• android-em-7-0-x86_64-shippable-lite-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1786982&startday=2022-08-22&endday=2022-08-28&tree=all

Comment 5

[Sean Feng [:sefeng]]

Looking it now

Comment 6

[Sean Feng [:sefeng]]

Attachment: repro.patch

I think this is regressed by bug 1783069.

I didn't find the root cause, looks like "loadeddata" was fired before the VideoElement gets the video? With the attached patch this should be reproducible reliably on not only mobile but also desktop.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1783069

Comment 8

[Emilio Cobos Álvarez (:emilio)]

D'oh, yeah, the test is just broken.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1786982 - Fix video-aspect-ratio.html. r=sefeng

The test was broken, had multiple calls to t.done(), etc.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/773b34cdfeb7
Fix video-aspect-ratio.html. r=sefeng

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35762 for changes under testing/web-platform/tests

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/773b34cdfeb7

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sefeng, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc997d3526d0

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Sean Feng [:sefeng]]

I shouldn't be assigned

Comment 17

[Intermittent Failures Robot]

23 failures in 3537 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• mozilla-central: 8
• mozilla-beta: 2

Platform and build breakdown:

• android-em-7-0-x86_64-lite-qr: 5
  • opt: 5
• android-em-7-0-x86_64-qr: 13
  • debug: 11
  • opt: 2
• android-em-7-0-x86_64-shippable-lite-qr: 4
  • opt: 4
• android-em-7-0-x86_64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1786982&startday=2022-08-29&endday=2022-09-04&tree=all