Open Bug 1787002 Opened 2 years ago Updated 2 years ago

Unconfirmed downloads of conflicting filenames can delete conflicting files after disk is full

Categories

(Toolkit :: Downloads API, defect, P3)

Firefox 102
Desktop
All
defect

Tracking

()

UNCONFIRMED

People

(Reporter: ed7-aspire4925, Unassigned)

Details

(Whiteboard: [downloads-cluster-2022])

Steps to reproduce:

In 102.1.0esr (Debian), and with downloads prompts enabled:

  1. Attempt to download a file whose:
  • size is larger than the free disk space of the destination, and
  • name conflicts with that of an existing file.
  1. Do not confirm the prompt; wait until the disk is full.

Actual results:

Both the download and conflicting files are deleted.

Expected results:

Only the download file is deleted.

Just in case, here is an fstab entry for a RAM disk to reproduce the issue in. Adjust the size to your liking.

tmpfs /mnt/ramdisk tmpfs size=128M,x-gvfs-show 0 0

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Downloads Panel

(In reply to ed7-aspire4925 from comment #0)

Steps to reproduce:

In 102.1.0esr (Debian), and with downloads prompts enabled:

  1. Attempt to download a file whose:
  • size is larger than the free disk space of the destination, and
  • name conflicts with that of an existing file.
  1. Do not confirm the prompt; wait until the disk is full.

Just to clarify... are you confirming the prompt once the disk is full? Or cancelling out of the prompt and still both files are deleted?

Flags: needinfo?(ed7-aspire4925)

I stopped at the confirmation prompt, downloads start automatically regardless.

Cancelling it out before the disk is full should be harmless.

Flags: needinfo?(ed7-aspire4925)
Component: Downloads Panel → Downloads API
Product: Firefox → Toolkit

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mak)
Severity: -- → S3
Flags: needinfo?(mak)
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → Desktop
Whiteboard: [downloads-cluster-2022]
You need to log in before you can comment on or make changes to this bug.