1787198 - Cache source text content based on the source actor not source

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

Source text content is currently cached in the reducers based on the source id, See code
But a source can can have multiple source actors, an the source text content's are fetched using the source actor See code
For breakpoints per url, we now have once source instance across multiple threads (multiple source actor). Its quite important to know the specific source actor which was used to load the source content.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1787198 - [devtools] Load source text with source actor

Comment 2

[Phabricator Automation]

Comment on attachment 9292213 [details]
Bug 1787198 - [devtools] Load source text with source actor

Revision D154778 was moved to bug 1789363. Setting attachment 9292213 [details] to obsolete.

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1787198 - [devtools] Change caching of symbols for original and generated source text content

Depends on D155952

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1787198 - [devtools] Change caching of original and generated source text content

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1787198 - [devtools] getSymbols support using source actor id and source id to cache symbols

Depends on D160018

Comment 6

[Phabricator Automation]

Comment on attachment 9299821 [details]
Bug 1787198 - [devtools] Change caching of symbols for original and generated source text content

Revision D160018 was moved to bug 1800093. Setting attachment 9299821 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9300890 [details]
Bug 1787198 - [devtools] getSymbols support using source actor id and source id to cache symbols

Revision D160696 was moved to bug 1800093. Setting attachment 9300890 [details] to obsolete.

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1787198 - Migrate Tab to use getSelectedLocation instead of getSelectedSource r=ochameau

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86544aef03e
Migrate Tab to use getSelectedLocation instead of getSelectedSource r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f49e8eca9e34
[devtools] Change caching of original and generated source text content r=ochameau

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d86544aef03e
https://hg.mozilla.org/mozilla-central/rev/f49e8eca9e34