Closed Bug 1787227 Opened 3 years ago Closed 3 years ago

Rename performance project flag name and values

Categories

(bugzilla.mozilla.org :: Administration, task)

Development

Tracking

()

RESOLVED FIXED

People

(Reporter: davehunt, Assigned: dkl)

References

Details

We'd like to improve the performance project flag introduced in bug 1749054 by making the following changes:

  • Rename the flag from "Performance" to "Performance Impact"
  • Replace the value "P1" with "high"
  • Replace the value "P2" with "medium"
  • Replace the value "P3" with "low"
  • Replace the value "-" with "none

Ideally these changes would apply to all existing bugs, but if it's necessary we can perform a scripted migration to the new values.

Flag update. Also any queries which reference cf_performance will also need to be changed to reference cf_performance_impact.

Assignee: nobody → dkl
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

(In reply to David Lawrence [:dkl] from comment #1)

Flag update. Also any queries which reference cf_performance will also need to be changed to reference cf_performance_impact.

Existing queries with cf_performance are returning no results, and when attempting to update them to cf_performance_impact I get the error "Can't use cf_performance_impact as a field name."

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I also noticed something odd in the bug history when this flag was set. See https://bugzilla.mozilla.org/show_bug.cgi?id=1709873#a25927085_396948

(In reply to Dave Hunt [:davehunt] [he/him] ⌚GMT from comment #2)

(In reply to David Lawrence [:dkl] from comment #1)

Flag update. Also any queries which reference cf_performance will also need to be changed to reference cf_performance_impact.

Existing queries with cf_performance are returning no results, and when attempting to update them to cf_performance_impact I get the error "Can't use cf_performance_impact as a field name."

This was due to the memcache not being cleared after the name change resulting in the old name still hanging around. I was able to clear it manually and fix the issue. I have filed bug 1787483 to address this in the future.

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
No longer blocks: 1866844
You need to log in before you can comment on or make changes to this bug.