1787274 - Cache offscreen status for accs that do not appear in the viewport

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Morgan Reschenberg [:morgan]]

Previously (see blocked bug) we cached offscreen status for accs that aren't within the active browsing context.
However, accs within the active browsing context can still be offscreen if they are not within that browsing context's visible viewport. We should address them here.
Maybe we can use the viewport cache we created in hittesting to help somehow?

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: WIP: Bug 1787274: Update browser_offscreen_element_in_out_of_process_iframe.js to invokeContentTask architecture

Depends on D155903

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8354032aaf6
Use mCachedFields viewport cache for determining offscreen state r=Jamie

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e8354032aaf6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for being the most-likely culprit for Fenix & Focus UI test bustage in today's Nightly AC bump.
https://hg.mozilla.org/mozilla-central/rev/49a271c42001f7bc5b9efadfc3e0b66dc0b67777

https://github.com/mozilla-mobile/fenix/pull/26859/checks?check_run_id=8231292916
https://github.com/mozilla-mobile/focus-android/pull/7622/checks?check_run_id=8232958157

Comment 6

[Morgan Reschenberg [:morgan]]

Hmm, I wonder if we're accidentally marking the document as offscreen... maybe IsActiveBrowsingContext doesn't work how we think it does on android...?

Comment 7

[Morgan Reschenberg [:morgan]]

without patch -- https://treeherder.mozilla.org/jobs?repo=try&revision=6ae128f3ca201d226b39f5cb565df2fb3b2b2dab
with this patch -- https://treeherder.mozilla.org/jobs?repo=try&revision=842ed929c27b7acad5cd819a291f04ee5b12fb21

Comment 8

[Ryan VanderMeulen [:RyanVM]]

To close the loop here, the backout did resolve the UI test failures we were seeing for both products.

Comment 9

[Atila Butkovits]

Backed out for causing geckoview failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/97a3e99ba5fd84c4e5044f8c0e0ecdb473ece7cd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7d2bb2e5fb73b79696c004192a1517f44585d50c&selectedTaskRun=TQR-lo89T3e-yRFFj8LZjQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=390490140&repo=autoland&lineNumber=2233

Comment 10

[Morgan Reschenberg [:morgan]]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=0fe9e2c5afc6f138cd1d54c2b938981aec9dfd0a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6376af715fb9
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6376af715fb9

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out for Fenix & Focus UI test failures.
https://hg.mozilla.org/mozilla-central/rev/e889c6465e4046a029e6654f1a897323b2a13674

https://firefoxci.taskcluster-artifacts.net/SKNiAwJvSD-38aA_i4n8HQ/1/public/results/HtmlErrorReport.html
https://firefoxci.taskcluster-artifacts.net/FljiYUjWS5GQ75gtEtdVVg/0/public/results/HtmlErrorReport.html

Comment 14

[James Teh [:Jamie]]

Morgan, if bug 1792603 proves difficult to fix (or it will take a long time for anyone to get to it), do you think it'd be feasible to work around it by looking at nearby frames as a proxy? For example, if a table cell is present but its row is not, we could "fudge" the table row into the array.

Comment 15

[Morgan Reschenberg [:morgan]]

(In reply to James Teh [:Jamie] from comment #14)

Morgan, if bug 1792603 proves difficult to fix (or it will take a long time for anyone to get to it), do you think it'd be feasible to work around it by looking at nearby frames as a proxy? For example, if a table cell is present but its row is not, we could "fudge" the table row into the array.

Yes, I have a partial working implementation. The only thing blocking this now is the test failure on the text mutation test that Eitan added in phab.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60a24f2c8b8
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish

Comment 17

[Cosmin Sabou [:CosminS]]

Backed out for causing mochitest failures on browser_test_visibility.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f9ec55a441c4554b04137a5420cbf288a920a9f7&test_paths=accessible%2Ftests%2Fbrowser%2Fstates%2F&selectedTaskRun=dqTLx2vwSMCMfWK5-bX4XQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=393558771&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a99882b97fbc5154a3bbf7c06d59fc159922f7c5

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7100398f71d2
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7100398f71d2

Comment 20

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1787274: Manually add combobox lists, options to the viewport cache r?eeejay,Jamie

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f9045997660
Manually add combobox lists, options to the viewport cache r=Jamie

Comment 23

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8f9045997660