Closed Bug 1787274 Opened 1 year ago Closed 1 year ago

Cache offscreen status for accs that do not appear in the viewport

Categories

(Core :: Disability Access APIs, defect, P2)

defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: morgan, Assigned: morgan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ctw-m3])

Attachments

(2 files, 1 obsolete file)

Previously (see blocked bug) we cached offscreen status for accs that aren't within the active browsing context.
However, accs within the active browsing context can still be offscreen if they are not within that browsing context's visible viewport. We should address them here.
Maybe we can use the viewport cache we created in hittesting to help somehow?

Severity: -- → S4
Priority: -- → P2
Blocks: a11y-ctw
Whiteboard: [ctw-m3]
Attachment #9292147 - Attachment description: WIP: Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie → Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie
Attachment #9292367 - Attachment is obsolete: true
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8354032aaf6
Use mCachedFields viewport cache for determining offscreen state r=Jamie
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 106 Branch → ---
Status: REOPENED → ASSIGNED
Flags: needinfo?(mreschenberg)

Hmm, I wonder if we're accidentally marking the document as offscreen... maybe IsActiveBrowsingContext doesn't work how we think it does on android...?

Flags: needinfo?(mreschenberg)

To close the loop here, the backout did resolve the UI test failures we were seeing for both products.

Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6376af715fb9
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Status: ASSIGNED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Depends on: 1792603

Morgan, if bug 1792603 proves difficult to fix (or it will take a long time for anyone to get to it), do you think it'd be feasible to work around it by looking at nearby frames as a proxy? For example, if a table cell is present but its row is not, we could "fudge" the table row into the array.

Flags: needinfo?(mreschenberg)
Attachment #9292147 - Attachment description: Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie → WIP: Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie

(In reply to James Teh [:Jamie] from comment #14)

Morgan, if bug 1792603 proves difficult to fix (or it will take a long time for anyone to get to it), do you think it'd be feasible to work around it by looking at nearby frames as a proxy? For example, if a table cell is present but its row is not, we could "fudge" the table row into the array.

Yes, I have a partial working implementation. The only thing blocking this now is the test failure on the text mutation test that Eitan added in phab.

Flags: needinfo?(mreschenberg)
Attachment #9292147 - Attachment description: WIP: Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie → Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r?Jamie
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d60a24f2c8b8
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7100398f71d2
Use mCachedFields viewport cache for determining offscreen state r=Jamie,geckoview-reviewers,owlish
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f9045997660
Manually add combobox lists, options to the viewport cache r=Jamie
Regressions: 1796876
You need to log in before you can comment on or make changes to this bug.