Closed Bug 1787358 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35629 - Change the `popup` invalid value default to "manual"

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35629 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35629
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Change the popup invalid value default to "manual"

Per the resolution [1], invalid values should now be treated as
if they were popup=manual. This lines up with the related change
[2] to the UA stylesheet for pop-up.

I also took the opportunity to expand the "basic" test to include
adding the popup attribute on all (visible) element types.

[1] https://github.com/openui/open-ui/issues/533#issuecomment-1227619710
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3840811

Bug: 1307772
Change-Id: I6d5bf956e344f9256ab9cc1bf3d30655c8dee5bf
Reviewed-on: https://chromium-review.googlesource.com/3858445
WPT-Export-Revision: 5b09f7914c9db98fbbbd46f5f23701d9fb91fe5f

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 2 tests and 117 subtests

Status Summary

Firefox

OK : 1
FAIL: 118

Safari

OK : 1
FAIL: 118

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-appearance.tentative.html [wpt.fyi]: FAIL (Safari: FAIL)
  • /html/semantics/popups/popup-attribute-basic.tentative.html [wpt.fyi]
    • The element <div popup="" id="boolean">Pop up</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="">Pop up</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="auto">Pop up</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="hint">Pop up</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="manual">Pop up</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <article popup="">Different element type</article> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <header popup="">Different element type</header> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <nav popup="">Different element type</nav> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <input type="text" popup="" value="Different element type"> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="true">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="popup">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div popup="invalid">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Safari: FAIL)
    • The element <div>Not a pop-up</div> should not behave as a pop-up.: FAIL (Safari: FAIL)
    • A <a> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <abbr> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <address> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <area> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <article> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <aside> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <b> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <bdi> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <bdo> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <blockquote> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <body> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <button> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <canvas> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <caption> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <cite> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <code> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <col> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <colgroup> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <data> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <dd> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <del> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <details> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <dfn> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <div> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <dl> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <dt> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <em> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <fieldset> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <figcaption> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <figure> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <footer> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <form> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h1> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h2> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h3> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h4> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h5> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <h6> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <header> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <hr> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <html> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <i> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <iframe> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <img> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <input> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <ins> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <kbd> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <label> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <legend> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <li> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <main> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <map> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <mark> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <menu> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <meter> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <nav> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <object> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <ol> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <optgroup> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <option> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <output> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <p> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <pre> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <progress> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <q> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <rt> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <ruby> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <s> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <samp> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <section> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <select> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <slot> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <small> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <source> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <span> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <strong> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <sub> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <sup> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <summary> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <table> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <tbody> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <td> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <textarea> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <tfoot> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <th> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <thead> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <time> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <tr> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <track> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <u> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <ul> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <var> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • A <video> element should behave as a pop-up.: FAIL (Safari: FAIL)
    • IDL attribute reflection: FAIL (Safari: FAIL)
    • Popup attribute value should be case insensitive: FAIL (Safari: FAIL)
    • Changing attribute values for pop-up should work: FAIL (Safari: FAIL)
    • Changing attribute values should close open pop-ups: FAIL (Safari: FAIL)
    • Removing a visible popup=auto element from the document should close the pop-up: FAIL (Safari: FAIL)
    • A showing popup=auto does not match :modal: FAIL (Safari: FAIL)
    • Removing a visible popup=hint element from the document should close the pop-up: FAIL (Safari: FAIL)
    • A showing popup=hint does not match :modal: FAIL (Safari: FAIL)
    • Removing a visible popup=manual element from the document should close the pop-up: FAIL (Safari: FAIL)
    • A showing popup=manual does not match :modal: FAIL (Safari: FAIL)
    • Exceptions are thrown even when show/hide are animated: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e672a71abb19 [wpt PR 35629] - Change the `popup` invalid value default to "manual", a=testonly https://hg.mozilla.org/integration/autoland/rev/15bf4092d3f7 [wpt PR 35629] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e672a71abb19
https://hg.mozilla.org/mozilla-central/rev/15bf4092d3f7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.