Closed Bug 178742 Opened 22 years ago Closed 22 years ago

[Mach-0] Bundle Info.plist needs work.

Categories

(SeaMonkey :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.2final

People

(Reporter: ccarlen, Assigned: ccarlen)

References

Details

Attachments

(4 files, 2 obsolete files)

bootstrap/macbuild/Contents/Info.plist
* has no doc type info in it - this causes a few problems
* has a version string of 0.9.7+
* doesn't have the right bundle name so when hovering over app icon, app name is
"mozilla-bin"
Attached patch patch (obsolete) — Splinter Review
most of this was ripped off from Chimera's bundle plist.
-> me.
Assignee: asa → ccarlen
Target Milestone: --- → mozilla1.2final
+	 <key>NSAppleScriptEnabled</key>
+	 <true/>

allows you to drag files onto the dock icon.
Attachment #105385 - Attachment is obsolete: true
Attachment #105953 - Flags: superreview?(sfraser)
Attachment #105953 - Flags: review?(pinkerton)
+	<key>CFBundleGetInfoString</key>
+	<string>Mozilla 1.2, © 1998-2002 The Mozilla Organization</string>

1.2 will have to be changed, depending on where this gets checked in, if it gets
checked into 1.2 branch, etc. JJ, are you the one who sets the version numbers
of Mac builds when branches are cut? If so, the Mach-0 bundle plist should
become part of that.
Status: NEW → ASSIGNED
Attachment #105953 - Flags: superreview?(sfraser) → superreview+
Comment on attachment 105953 [details] [diff] [review]
Add NSAppleScriptEnabled key

+	<string>Mozilla 1.2, © 1998-2002 The Mozilla Organization</string>

is the  a typo?

r=pink
Attachment #105953 - Flags: review?(pinkerton) → review+
Mike: Not a typo, this file is unicode.
Conrad: Do we actually need a separate Info.plist for the cfm and the mach-o
build? As part of the version string update process, we already take care of
mozilla/xpfe/bootstrap/mozilla.plst (used for cfm), but if needed, I'll also add
this one to our checklist.
> is the � a typo?

<?xml version="1.0" encoding="UTF-8"?>

If, when viewing the attachment, you chose UTF-8 from View->Character Coding,
the mystery character actually shows up as what it should be :-)
I checked in the patch on the trunk with the version id updated to 1.3a.  Simon
says that separate files are needed since the binary names differ.
Thanks, though I would've thought this would go in after bug 111797. By having
those doc types in the bundle, we're saying we can accept things that we can't.
Not a huge deal, and as long as 111797 goes in soon...
*** Bug 130722 has been marked as a duplicate of this bug. ***
Bug 111797 went in yesterday.  Do we want to get the version change into 1.2f or
are we done here?
I think we're done here. I don't think we need to go back to 1.2 and add this
info, since 1.3 will be our first real Mach-0 release.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Info.plist needs some work again, I think this should be reopened.

Specifically, we now have a more extensive icon set. These Icons have to be
referenced.

See: http://bugzilla.mozilla.org/show_bug.cgi?id=88393
The new Info.plist has to be checked in alongside the icon set itself, which is
to be found here: http://www.theparallax.org/sd/mozilla/mozilla-icons.tgz I
have renamed the icon files according to my proposition.
Attached file Updated Info.plist (obsolete) —
I have updated the Info.plist according to the last attachment. This introduces
associations with the following filetypes:

* Mozilla Preferences File
* Mozilla Plugin
* Mozilla Command Line File
* Mozilla Shared Library
* Mozilla Binary File

It slightly updates or completes support for:

* Text Document
* HTML Document

Support for image files remains unchanged - say "slightly broken" - as it still
references a nonexistent icon file, albeit one with a more meaningful name. :)

CFBundleIconFile has been changed from "mach" to "mozilla.icns"

Please review the changes and check in, if okay. Thanks!
Attachment #123302 - Attachment is patch: true
Attachment #123302 - Flags: superreview?(sfraser)
Attachment #123302 - Flags: review?(pinkerton)
Attachment #123302 - Attachment is patch: false
Attachment #123302 - Attachment mime type: text/plain → application/xml
Associate plug-in icon with ".plugin" extension.

I suggest associating the shared library icon with the ".dylib" extension also.

Associate ".log" extension with text icon.

Associate other image formats Mozilla supports with the image icon, such as
PPM6, BMP, ICO, XBM (taken from <http://www.libpr0n.com/faq.html>) which I
presume are ".bmp", ".ico", and ".xbm". Also include ".jfif" and ".jng".
Agreed, added. Do you know the CFBundleTypeOSTypes of these file types?

As a side note: Does anybody know when exactly a CFBundleURLIconFile will be
shown for a specific URL? - We don't have these icons yet and I'm thinking
about opening a seperate bug on these once we are finished with these changes.
Attachment #123302 - Attachment is obsolete: true
Attachment #123302 - Flags: superreview?(sfraser)
Attachment #123302 - Flags: review?(pinkerton)
Attachment #123330 - Attachment is patch: false
Attachment #123330 - Attachment mime type: text/plain → application/xml
Attachment #123330 - Flags: superreview?(sfraser)
Attachment #123330 - Flags: review?(pinkerton)
can i see a diff? and why is this bug marked fixed?
Attached file Diff of both versions
The Problems this bug was originally created for were fixed. I was thinking
about opening a separate bug for that, but it seemed to me that this bug
generically handles small adjustments that have to be done to Info.plist
whenever new features come up. If not, then that’s my fault. - See Comment #13
for more info.
One thing: CFBundleShortVersionString of course has to become 1.4b, 1.4 RC1, 1.4
or whatever, but that this is being changed anyway when new versions come out.
Simon, you should probably attach your Info.plist to bug 88393 instead of this one.
Comment on attachment 123330 [details]
further revised Info.plist

i say we create a new bug for the remaining issues. this is kinda old by now.
Attachment #123330 - Flags: superreview?(sfraser)
Attachment #123330 - Flags: superreview-
Attachment #123330 - Flags: review?(pinkerton)
Attachment #123330 - Flags: review-
Which remaining issues do you mean, Mike? CFBundleURLIconFile? - Anyway, please keep us updated 
about the new bug when you create one.

If there's any graphic stuff (more icons?) to be done i could certainly help out.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.