1787560 - Add test that exercises a scrollbar drag

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Dan Robertson (:dlrobertson)]

It would be nice to have a test that exercises a hit-test that should result in a scrollbar drag hit (bug 1787361).

Comment 1

[Timothy Nikkel (:tnikkel)]

We must have tests that do this for mouse moves already. Maybe you can modify an existing test to use touches.

Comment 2

[Botond Ballo [:botond]]

(In reply to Timothy Nikkel (:tnikkel) from comment #1)

We must have tests that do this for mouse moves already. Maybe you can modify an existing test to use touches.

Yeah, good point, here's one: https://searchfox.org/mozilla-central/source/gfx/layers/apz/test/mochitest/helper_drag_root_scrollbar.html

The logic inside promiseVerticalScrollbarDrag() takes care of a bunch of details related to targeting scrollbars (e.g. checking for overlay, working around scrollbar buttons) that could be reused for targeting touch events at them.

Comment 3

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1787560 - Add test for touch drag scrollbar scroll. r=botond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4274430f48d6
Add test for touch drag scrollbar scroll. r=botond

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_test_scroll_thumb_dragging.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0afe8aa05c5ad02f319767a8da0a70db437e246a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=AGoJXsWTSdqFgBSHEbCBww.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4274430f48d6da2c1acbdac04e60338f4c2461c1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=388975610&repo=autoland&lineNumber=3600

Comment 6

[Dan Robertson (:dlrobertson)]

Ah, I messed up the parameter rename for promiseVerticalScrollbarDrag.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b127ef129fa
Add test for touch drag scrollbar scroll. r=botond

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3b127ef129fa