1787601 - mach vendor rust --ignore-modified failed in non git repository: "no such subcommand: `vet`"

Status: RESOLVED INVALID

(Firefox Build System :: Mach Core, defect)

Description

[Alex Fan]

Steps to reproduce:

run mach vendor rust --ignore-modified when firefox src is not managed in a git repository. Or simply, mv .git no_git

Actual results:

With .git, this command works perfectly.
With .git renamed or removed, it fails with

error: no such subcommand: `vet`                                                                                    
                                                                                                                    
        Did you mean `new`?                                                                                         
Error running mach:                                                                                                 
                                                                                                                    
    ['vendor', 'rust', '--ignore-modified']

I tried to track down the problem, and found in https://github.com/mozilla/gecko-dev/blob/2f47697ff541a61c26deabece15365f6cbac7728/python/mozbuild/mozbuild/mach_commands.py#L214 , bootstrap_toolchain("cargo-vet") returns null, whereas in normal case, it returns /home/alexfanqi/.mozbuild/cargo-vet

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Mach Core' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alex Fan]

Sorry, didn't realise mach vendor rust is not intended to be used with non git/vcs src previously.