178767 - Should use hourglass w/ pointer for mouse cursor when loading new newsgroup

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[WD]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021106
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021106

In windows, there are generally 2 "busy" mouse cursors.  One being just an
hourglass, and the other being a pointer but with an hourglass beside it.  The
former indicates that no interaction with the current window should be possible,
while the latter indicates that it's busy but interaction is still possible. 
When a new newsgroup is clicked it uses the hourglass cursor.   Since you can
still scroll the message headers, etc., it should be a pointer with an hourglass
instead.

Reproducible: Always

Steps to Reproduce:
1.Click on a new newsgroup to load the headers
2.
3.

Actual Results:  
The mouse cursor is an hourglass

Expected Results:  
The mouse cursor is a pointer with an hourglass beside it

Comment 1

[WD]

Attachment: Patch to use "Spinning" cursor, rather than "Wait"

Comment 2

[Jan Varga [:janv]]

I haven't tried this patch, but it seems we're correctly handling the spinning
cursor on linux and mac too.
http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsWindow.cpp#1233
http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsWindow.cpp#738

Seth, are you ok with this patch ?

Comment 3

[Jan Varga [:janv]]

Comment on attachment 105685 [details] [diff] [review]
Patch to use "Spinning" cursor, rather than "Wait"

r=varga

Comment 4

[(not reading, please use [e-mail] instead)]

what about the other place we call SetBusyCursor()?

is interaction possible in those cases?

Comment 5

[WD]

Seth:

The only place I see this particular SetBusyCursor() being called is from
ChangeFolderByURI  , and other interaction is indeed possible here.

Or are you asking if the other SetBusyCursor() functions should also be updated
similarly?
Here:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/directory/directory.js#105
and:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/FilterEditor.js#657

Comment 6

[WD]

Can this be checked in?   The "wait" hourglass is deceptive, since interaction
is really possible while it's being showed via SetBusyCursor().

Comment 7

[Matthias Versen [:Matti]]

Comment on attachment 105685 [details] [diff] [review]
Patch to use "Spinning" cursor, rather than "Wait"

This patch is old, very old and SSpitzer never SR'ed it.
Neil can you take a look at it ?

Comment 8

[[e-mail]]

Comment on attachment 105685 [details] [diff] [review]
Patch to use "Spinning" cursor, rather than "Wait"

>+            window.setCursor("spinning");
The correct namne for this is "progress" ("spinning" is deprecated).
sr=me with that fixed.

Comment 9

[Justin Wood (:Callek)]

$ hg outgoing -v && hg push
running "ssh hg.mozilla.org "hg -R comm-central/ serve --stdio""
comparing with ssh://hg.mozilla.org/comm-central/
searching for changes
changeset:   448:11c3f936a257
tag:         tip
user:        WD <[e-mail]>
date:        Sat Sep 27 11:50:43 2008 -0400
files:       mailnews/base/resources/content/msgMail3PaneWindow.js
description:
Bug 178767, Should use hourglass w/ pointer for mouse cursor when loading new newsgroup
r+sr=NeilAway


pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files