178772 - doeditparams.cgi failed with malformed headers

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

doeditparams.cgi fails on the trunk with a server error after I edit params and
then submit my changes.  The Apache log says:

[Wed Nov  6 17:56:36 2002] [error] [client 64.236.139.249] malformed header from
script. Bad header=We don't have shadow databases:
/opt/webtools/bugzilla-test/doeditparams.cgi

"We don't have shadow databases" appears in syncshadowdb, which is somehow being
called first, even though doeditparams.cgi returns HTTP headers before it does
almost everything.

Comment 1

[Bradley Baetz (:bbaetz)]

This is a dupe of bug 177316, which was reported by joel, and then later marked
by him  as WFM.

The bad news is that there is no way I will be looking at this before Friday
afternoon. The good news is that my Fri afternoon is your Thursday evening,
which gives us more time.

Comment 2

[Joel Peshkin]

The easy fix for this is to yank line 97 of syncshadowdb.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Bizarre.  By writing to STDERR, syncshadowdb appears to be purging the pipe of
existing output in favor of its own.

Comment 4

[Joel Peshkin]

OK, this is officially bizzarre....

This fails on my solaris 7 machine with perl 5.6.1 built from source
and passes on my Linux system with the same perl source build.

Key CPAN module are the same.

Comment 5

[Bradley Baetz (:bbaetz)]

I'm guessing apache version changes, or just an OS thing wrt file handles
inheriting over fork.

Why don't we just wrap the system call from doeditparams in a if
(!Param("shadowdb"))

?

Comment 6

[Joel Peshkin]

Attachment: Patch

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 105507 [details] [diff] [review]
Patch

r= justdave
a= justdave

Comment 8

[Joel Peshkin]

Checking in doeditparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/doeditparams.cgi,v  <--  doeditparams.cgi
new revision: 1.22; previous revision: 1.21
done

Comment 9

[Bradley Baetz (:bbaetz)]

The real cause of this was bug 179174.