Closed Bug 1787797 Opened 2 years ago Closed 2 years ago

Firefox View button in Tools menu opens unselected tab when Fx View removed from tabstrip

Categories

(Firefox :: Firefox View, defect, P2)

Desktop
All
defect
Points:
2

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox106 --- verified

People

(Reporter: jberman, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

Steps

  1. Remove Fx View from Tab strip
  2. Click "Tool" Menu
  3. Click Firefox View

Actual: When I use the "Tool" menu to open Fx View and it is not in my tab strip, Fx View opens but no tab is selected.
Recommended resolution: Conditionally change button language in "tool" menu so that when Fx View has been removed from tabstrip/toolbar then the button reads "Restore Firefox View" (need copy support). Expected functionality would be that Firefox View is restored in its place as a pinned tab, and then that the Fx View tab is selected.

Flags: needinfo?(rfambro)
Flags: needinfo?(mwalkington)
Severity: -- → S3
Flags: needinfo?(rfambro)
Priority: -- → P2

(In reply to Josh Berman from comment #0)

Recommended resolution: Conditionally change button language in "tool" menu so that when Fx View has been removed from tabstrip/toolbar then the button reads "Restore Firefox View" (need copy support). Expected functionality would be that Firefox View is restored in its place as a pinned tab, and then that the Fx View tab is selected.

For the sake of keeping the scope minimal here, I'm going to leave the menu item labeled as is and have it just silently re-add the button if needed.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Points: --- → 2

I think this alternate recommendation should work. Thanks Dao!

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3d008809e7c
Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Flags: needinfo?(mwalkington)
Flags: qe-verify+

Reproduced the initial issue using an old Nightly build from 2022-08-29 as described in comment 0, verified that this is no longer an issue using latest Firefox 106.0b5 across platforms (Windows 10, macOS 11.6 and Ubuntu 21.04).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: