1787797 - Firefox View button in Tools menu opens unselected tab when Fx View removed from tabstrip

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Josh Berman]

Attachment: Screen Recording 2022-08-29 at 10.17.35 AM.mp4

Steps

1. Remove Fx View from Tab strip
2. Click "Tool" Menu
3. Click Firefox View

Actual: When I use the "Tool" menu to open Fx View and it is not in my tab strip, Fx View opens but no tab is selected.
Recommended resolution: Conditionally change button language in "tool" menu so that when Fx View has been removed from tabstrip/toolbar then the button reads "Restore Firefox View" (need copy support). Expected functionality would be that Firefox View is restored in its place as a pinned tab, and then that the Fx View tab is selected.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Josh Berman from comment #0)

Recommended resolution: Conditionally change button language in "tool" menu so that when Fx View has been removed from tabstrip/toolbar then the button reads "Restore Firefox View" (need copy support). Expected functionality would be that Firefox View is restored in its place as a pinned tab, and then that the Fx View tab is selected.

For the sake of keeping the scope minimal here, I'm going to leave the menu item labeled as is and have it just silently re-add the button if needed.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster

Comment 3

[Ray Fambro]

I think this alternate recommendation should work. Thanks Dao!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d008809e7c
Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d3d008809e7c

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build from 2022-08-29 as described in comment 0, verified that this is no longer an issue using latest Firefox 106.0b5 across platforms (Windows 10, macOS 11.6 and Ubuntu 21.04).