Closed Bug 1787957 Opened 2 years ago Closed 2 years ago

High CPU & Freeze w/Bitwarden copy

Categories

(WebExtensions :: General, defect)

Firefox 104
defect

Tracking

(Performance Impact:?, firefox104 wontfix)

RESOLVED DUPLICATE of bug 1774285
Performance Impact ?
Tracking Status
firefox104 --- wontfix

People

(Reporter: 4myforums, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.102 Safari/537.36 Edg/104.0.1293.70

Steps to reproduce:

Use Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Firefox/104.0
Build ID: 20220818191623

  • Open 10 or more tabs.
  • Access Bitwarden (either web site or app)
  • select a vault entry and click on copy of one of the credential, e.g., userid or password
  • Bitwarden return a message confirming the copy

Actual results:

FF unresponsive and CPU usage in Task Manager jumps to 30% or more and stays there for some time. Time is longer if more tabs are open. With about 40 active tabs the freeze can be for 1 minute.

Expected results:

No high CPU or freeze.
No freeze with only a couple of tabs open.
This problem seems to be new withing the last month, but cannot confirm when it started.
This problem does not happen with Edge so it does not seem to be a Windows or Bitwarden issue.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Password Manager' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Password Manager
Product: Firefox → Toolkit

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true

:fdoty this is marked as a Password Manager component, but do you think this should be a performance issue?

Flags: needinfo?(fdoty)
QA Whiteboard: [qa-regression-triage]

I found that the problem can be repeated on some forum websites. I found 3 that have this problem but one that does not.

The steps are:

  • select a posting
  • enter some text in the Reply section
  • mark that text
  • do a cut via Ctrl-x to induce the freeze.
    The length of the FF freeze is proportional to the number of active tabs.

Interestingly, performing the above steps on this reply did not result in a freeze.

It seems that it is not isolate to a password manager, and the Component of bug report may be incorrectly classified.

A File, Edit, Cut cause the freeze as well, but a Ctrl-C or File, Edit, Copy does not.

Also, there is no freeze if these operations are performed from the Search box or the URL bar.

I've created a trial account on Bitwarden, uploaded a bunch of random accounts, then opened up to about 100 websites in different tabs and attempted reproduction by selecting a specific credential from the web-vault and then clicking the "copy" button from either the username or password, however, but I could not reproduce this issue in Release v104.0 or 104.0.1 on Window 10. The message was displayed as expected and no freeze was observed.

Considering the other reproduction steps in comment 5 and 6, I would like some more information in order to attempt a regression investigation.
@Chris: Which forum websites does this reproduce in, on your side? What do you mean by "mark that text"? What else might I have missed from the reproduction steps?

Flags: needinfo?(4myforums)

The sites where the freeze were observed are:
https://www.digitalhome.ca/forums/
https://forums.grc.com/
https://www.elevenforum.com

It does not happen with this web site:
https://community.koodomobile.com/

I also have the following add-on installed:

  • Bitwarden - Free Password Manager
  • DuckDuckGo Privacy Essentials
  • Tab Session Manager
  • Tree Style Tab
  • uBlock Origin

The freeze still happens when they were all disabled, but without restarting FF.

My meaning of "mark that text" is to use the cursor to highlight some text in the Reply window, and then do a Ctrl-x to cut that text and put it on the Windows Clipboard.

Performance Impact: --- → ?
Flags: needinfo?(fdoty)

Another test and additional information:

  • disabled all add-on and closed FF
  • restarted FF and it opened on the add-on page
  • did a Ctrl-2 to navigate to one of the forum web sites that remembers my credentials
  • entered some text in the Reply box
  • used the cursor to mark that text
  • did a Ctrl-x, and immediately followed by typing xxxxxxx
  • the text was deleted, three or four x's were entered and then FF froze for a short while then the addition x's were displayed
  • opened 8 more tabs using Ctrl-1, 2, 3, 4, etc
  • when back to forum site via Ctrl-2
  • repeated the Ctrl-x and xxxxxxx test
  • this time the freeze was for a longer time after the three or four x's were displayed

I am using vertical tabs along with the Tree Style Tab. The tabs are not shown on the side or top when the tab is disabled.

If this does not help I will restore my system to an earlier version of FF and Win 11 (early July) which is prior to when I think the problem started. Can do this on Wed to Fri, but will then be away for 5 days.

Flags: needinfo?(4myforums)

Additional research to pinpoint the point of failure.

Restored system to an early July backup

  • Win 11 22H2, OS Build 22621.160, FF ver 102.0 - no freeze
  • update to FF 104.0 - no freeze
  • updated to Win 11 22h2, OS Build 22621.590 - no freeze
  • updated to Win 11 22H2, OS Build 22622.590, Feature Pack 1000.22634.1000.0 - freeze

Restored system to an early July backup

  • Win 11 22H2, OS Build 22621.160, FF ver 102.0 - no freeze
  • updated to Win 11 22h2, OS Build 22621.590 - no freeze
  • updated to Win 11 22H2, OS Build 22622.590, Feature Pack 1000.22634.1000.0 - freeze

So the issue appear to be with Win 11 2262.590 (which is expected to GA in October) and FF.

Bitwarden should be removed from the bug title, and the Component of Password Manager should be changed.

Hope this helps.

Hello,

I have tried to reproduce this issue with all the specified information from Description, comment4, comment 7 and comment 8 using 104.0.2, 106.0a1 and 105.0b9 but was unable to isolate this issue.

I am running Win 11 PRO 22H2 (22622.590) - Insider Preview build /Beta Channel on an i7-7700k, GTX 1060, 16GB RAM and the OS installed on an SSD.

Chris, if you are still able to reproduce this issue, I have to ask you to help us by regressing it yourself, using a tool called mozregression. (https://mozilla.github.io/mozregression/)

I will write you a number of steps to take in order to do it correctly:
install mozregression:

a. Download this executable:
https://github.com/mozilla/mozregression/releases/download/5.0.0/mozregression-gui.exe
b. Instal the app.
You have to determine a build that reproduces the issue.
Then you should find one that does NOT reproduce it. Detailed steps:
a. Open Mozregression app;
b. Click "File" -> "Run a single build";
c. On the "Single Run Wizard" pop-up, "Basic configuration" page, change parameter "Build type" from "shippable" to "opt" and click "Next".
d. On the "Profile selection" page, just click the "Next" button.
e. On the "Build selection" page, change the "date" parameter to "release" by it's drop-down.
f. Then select a release number (numbers lower than 68 until you find one that does not reproduce the issue) on the from the drop-down on the left and click "Finish".
g. Now the mozregression app will open a firefox build of the selected release number and you can use it, close it and open another. (make a note of the version that does not reproduce the issue)
You will use mozregression app to "bisect" builds that reproduce the issue by builds that do not reproduce it in search of the one build/changeset that introduced the issue, in the first place:
a. Open mozregression-gui.exe
b. Click "File" -> "Run a new bisection"
c. On "Basic configuration" screen, select Build Type: "opt" and click "Next" button.
d. Skip "Profile selection" screen by the "Next" button.
e. On the Bisection wizard screen, you will need to select a build that reproduces the issue and one that does not:
e1. In the "Last known good build:" section, select "date" on the right drop-down and the date of the build you found NOT to reproduce the issue.
e2. In the "First known bad build:" section, select "date" on the right drop-down and the date of the build you found to reproduce the issue.
f. Click "Finish" to start the bisection process.
g. Builds will open one-by-one, you will need to test each one of them and see whether the issue reproduces. If it reproduces, then you need to select the "bad" button in the mozregression window and if not, you need to select the "good" button.
h. When bisection is done, you will have the information in the "Log View" section of the mozregression window; bisection may also fail due to not enough builds, but the logs can always be useful.

Copy the logs in a text file and attach it to this bug.
If there is still information you need regarding the regression process, please request information from me.
Thank you for your contribution!

Flags: needinfo?(4myforums)
Attached file Regression test log
Flags: needinfo?(4myforums)

Regression log attached.
Note: the test were done running Win 11 22H2 OS Build 22622.590 where the problem was first noticed.

Repeated the tests with rel 9x. 1xx are problems

Simplified test procedure:

  1. Open FF to a blank tab (no history), or from the mozregression-gui
  2. Paste this site "https://www.digitalhome.ca/login/" into the search bar and press enter
  3. Type "xxxxxxxxxxxx" into the Username or Email box
  4. Press Ctrl-x and immediately hold down some key

If the key responds immediately with no glitches then the test is successful. If only a couple of characters are displayed, then a freeze, eventually followed by more characters then the test has failed.

As mentioned in Comment 9, FF is freezing with Win 11 22H2 ( but running the mozregression I was able to find some old FF versions that did not freeze).

Component: Password Manager → General
Product: Toolkit → WebExtensions

Hello,

I’m from Webextensions QA and the issue ended up in our triage, however, Comment 9 states that Bitwarden is not the issue here or any other extension for the matter, if I correctly read through the other comments.

As such, can the issue be moved to a more appropriate Component and Product? Thank you!

I DID try to reproduce the issue as per Comment 14, with and without Bitwarden, on the latest Firefox Release 104.0.2 under Windows 10 x64 (I do not have a machine running Win11), however without success. There is no freezing occurring in either case whatsoever.

Just to confirm, it appears that this problem is limited to Win 11 22H2 (Beta to be released in Oct 2022). Do not waste time trying to reproduce it with Win 10, or released Win 11 21H2 (it does not freeze on this version)
Additional tests:

  • clean boot
  • run mozregression-gui, select Single Build, opt, and Next, Next, and Finish
  • run the tests in Comment 14, steps 2-4, freeze experienced
  • open a new tab
  • run the tests in Comment 14, steps 2-4, NO freeze experienced
  • start regular FF with all previous tabs open
  • Ctrl-shift-p
  • run the tests in Comment 14, steps 2-4, NO freeze experienced

The severity field is not set for this bug.
:zombie, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tomica)

I have uninstall FF with Revo Uninstaller, so no traces of FF should be left. Clean installed FF and repeated the test, same problem. Some additional info:

Desktop PC Win11 22621.356 official 22H2 September release

  1. Normal window - no freeze

Laptop Win11 22622.601, Beta 22H2, using FF default-release Profile (lots of customizations & addons)
2. Normal window - always freeze
3. Private window - no freeze

Laptop Win11 22622.601, new FF Test1 Profile (no customizations)
4. No addons - freeze on 1st test, no freeze on subsequent test
5. Private window - no freeze

I plan to clean install Win 22H2 after the October release, and suspect that the problem will no longer exist. It is a very strange bug.

Breaking news!!!!!

  1. Uninstalled Widows Feature Update KB5015669 (with File Explorer Tabs)
  2. Ran tests - no freeze
  3. Added KB5015669 to Desktop PC
  4. Ran test - freeze
  5. Repeated steps 1 & 2 with same results
  6. Installed KB5015669 to Desktop PC
  7. Ran tests - freeze

So the problem lies between FF and KB5015669 (which has not been released outside of the Windows Insider Program). Whatever is going on there could change by the time it is officially released in October.

I will be reporting the problem to the Windows Feedback Hub as well.

Microsoft confirms this problem and have stated that "We've just included a fix that should address this with Build 22494".

This bug can be closed as it only relates to the Insider stream.

Cancel comment #20. The Feedback Hub was corrupted and incorrectly reported the fix as build 22494 was from November 2021.

Closing as incomplete, if this reproduces with a release build of Windows, feel free to reopen.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(tomica)
Resolution: --- → INCOMPLETE

Wiped HDD and clean installed official Win 11 22H2, OS Build 2261.675. Installed FF 106.0.1, with no addons.

  1. Open 5 tabs of FF Settings, and digitalhome.ca (6 tabs total). Close FF (remembering previous open tabs).

  2. Start Task Manager

3.Open FF and select each tab. Select Logon from digitalhome.ca, enter a text string in the Username field, and select the text string.

  1. Wait for FF CPU usage in Task Manager to drop to 1%.

  2. Do a Ctrl-x, and hold down any key. A few characters are entered, a small freeze with CPU usage jumping to 28%. FF resumes then more character are entered.

  3. Enter a text string in the Username field, and select the text string.

  4. Wait for FF CPU usage in Task Manager to drop to 1%.

  5. Do a Crtl-x, and hold down any key. This time there is no freeze, all characters are entered, and CPU usage only goes up to 3%.

Same results if steps 3 to 8 are repeated.

Install FF addons, uBlock Origin, Tree Style Tabs, TabSessionManager, DuckDuckGo Privacy Essentials, and Bitwarden.

  1. Start Task Manager

  2. Open FF (148 tabs - all inactive), select 10 tabs. Select Logon from digitalhome.ca, enter a text string in the Username field, and select the text string.

  3. Repeat steps 4 to 8. In step 5 the CPU usage jumps to ~48%. In step 8 the CPU usage also jumps to ~48%. In both steps the repeated text from holding down a key is lost.

I did another mozregression bisection, more reliable than the previous ones, and found that 86.0a1 was OK, and 87.0a1 was not.

Attached file FF-Bisect.txt
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

The Windows setting of DEP appears to have an influence on this performance issue (Settings, System, About, Advanced system settings, Performance & Settings, Data Execution Prevention, Turn on DEP for all programs and services).

Results on my i5-8250U laptop with DEP turned on for all programs and service:

  • issue exists for both regular FF & mozregression instance

Results on my i5-8250U laptop with DEP turned on for Windows programs and services:

  • issue reduced for regular FF
  • no issue with mozregression instance

On an i3-8100T desktop (same Win OS version) no freeze with DEP set for Windows programs and services, but less severe freeze than the laptop with DEP for all programs and service.

In summary, the CPU spike is worse on this laptop. The degree of freeze:

  • no freeze with Ctrl-x in this Add Comment box
  • some freeze with Ctrl-x in a website userid or password field
  • major freeze from the copy username or password from the Bitwarden View Item window (original report of the problem)
  • no issues when performing equivalent activities with the Edge browser

Changing accessibility.force_disabled from 0 to 1 appears to resolve the high CPU/freeze issue.

This was not necessary on another Win 11 PC or on a Win 10 PC, so there is something unusual with this laptop.

Changing accessibility.force_disabled from 0 to 1 appears to resolve the high CPU/freeze issue.

I have been experiencing random freezes on my laptop running Win11 22621.755, and I can confirm that this change worked for me as well.

That issue might be the same as bug 1774285, for which we have a patch coming and a workaround described in https://support.mozilla.org/en-US/kb/firefox-hangs-when-copying-suggested-actions-windows-11, Chris could you test the workaround and confirm if this is the same issue? Thanks

Flags: needinfo?(4myforums)
See Also: → 1774285

Yes, it appears to be the same issue. Changing accessibility.force_disabled back to 0, and disabling Suggested Actions does eliminate the freeze. However there is still a small jump with the CPU usage, particularly with the copy username or password from Bitwarden.
I am relieved by this discovery and acknowledgement. Thanks, and I look forward to the the permanent fix.

Flags: needinfo?(4myforums)
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Duplicate of bug: 1774285
Resolution: --- → DUPLICATE

What I don't understand is why the freeze is not experienced on my desktop PC that is running the latest Win 11 22h2, build 22621.755 (same with some prev versions). accessibility.force_disabled=0 and Suggested Actions is enabled. The new Win feature for the popup of a quick action works so the latter function is working.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: