1788271 - Improve Windows Event logging of parameters

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[David Parks [:handyman]]

The WindowsEvent log records windows messages (e.g. WM_KEYDOWN) sent to our widgets. It writes some important message types by string name. It also writes the wParam and lParam as raw numbers. For at least some of those events, the parameter values are encoded and could be better displayed while for some others the values are useless -- for example, they are pointers to temporary objects (e.g. lParam in WM_WINDOWPOSCHANGING) or bit-fields (e.g. lParam in WM_KEYDOWN). In these cases, we should log the actual useful values for these parameters.

As a bonus, since the messages sometimes use structs in wParam/lParam as output parameters, we might also want to try to log that as well. We might even be able to make the choice of when to log as input vs output vs both, based on the meaning of the specific window message. For example, that struct in the lParam in WM_WINDOWPOSCHANGING is used as both input and output.

We should also add a second log or env var or something, specifically to control whether mouse and repeat events are recorded, since they can spam the log. The current code uses #defines to handle this, so it requires rebuilding to toggle.

Some of this was discussed in bug 1751281.

Comment 1

[Greg Stoll :gstoll]

Attachment: Bug 1788271 - Part 1: log some Windows messages before and after we process them r=handyman

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 1788271 - Part 2: set up utilities to log more info about Windows messages r=handyman

Depends on D159197

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 1788271 - Part 3: richer logging for a bunch of Windows messages r=handyman

Depends on D159198

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1788271 - Part 2.5: add tests for Window message logging utilities r=handyman

Depends on D159198

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35c8f019bb72
Part 1: log some Windows messages before and after we process them r=handyman
https://hg.mozilla.org/integration/autoland/rev/41ed1cd101e2
Part 2: set up utilities to log more info about Windows messages r=handyman
https://hg.mozilla.org/integration/autoland/rev/f7ec71342782
Part 2.5: add tests for Window message logging utilities r=handyman
https://hg.mozilla.org/integration/autoland/rev/3247add01341
Part 3: richer logging for a bunch of Windows messages r=handyman

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/35c8f019bb72
https://hg.mozilla.org/mozilla-central/rev/41ed1cd101e2
https://hg.mozilla.org/mozilla-central/rev/f7ec71342782
https://hg.mozilla.org/mozilla-central/rev/3247add01341