Closed Bug 1788307 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35652 - Modify the UA stylesheet to allow `<dialog popup>`

Tracking

(firefox106 fixed)

Status:

RESOLVED FIXED

Milestone:

106 Branch

Tracking Flags:

Tracking

Status

firefox106

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 35652 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35652
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Modify the UA stylesheet to allow <dialog popup>

This CL does two main things:

Convert the :-internal-popup-hidden to
:-internal-popup-opening-or-open

Add/modify rules for both dialog and [popup] so that they don't
add display:none when a \<dialog popup> is either open as a
dialog or pop-up.

See this issue for details:
https://github.com/openui/open-ui/issues/520

Bug: 1307772
Change-Id: I751f6991a988a58032cebd52f289e5468140ce79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856639
Commit-Queue: Mason Freed \<masonf@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: David Baron \<dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040576}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Whiteboard: [wptsync downstream] → [wptsync downstream error]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Whiteboard: [wptsync downstream error] → [wptsync downstream]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9af3addfcab2a3ce931e48273f3b695ae076f820

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 120 subtests

Status Summary

Firefox

OK : 1
FAIL: 120

Chrome

OK : 1
FAIL: 120

Safari

OK : 1
FAIL: 120

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/popups/popup-attribute-basic.tentative.html [wpt.fyi]
- The element <div popup="" id="boolean">Pop up</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="">Pop up</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="auto">Pop up</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="hint">Pop up</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="manual">Pop up</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <article popup="">Different element type</article> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <header popup="">Different element type</header> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <nav popup="">Different element type</nav> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <input type="text" popup="" value="Different element type"> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <dialog popup="">Dialog with popup attribute</dialog> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <dialog popup="manual">Dialog with popup=manual</dialog> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="true">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="popup">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div popup="invalid">Invalid popup value - defaults to popup=manual</div> should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <div>Not a pop-up</div> should not behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- The element <dialog open="">Dialog without popup attribute</dialog> should not behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <a> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <abbr> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <address> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <area> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <article> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <aside> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <b> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <bdi> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <bdo> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <blockquote> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <body> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <button> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <canvas> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <caption> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <cite> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <code> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <col> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <colgroup> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <data> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <dd> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <del> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <details> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <dfn> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <div> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <dl> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <dt> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <em> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <fieldset> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <figcaption> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <figure> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <footer> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <form> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h1> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h2> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h3> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h4> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h5> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <h6> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <header> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <hr> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <html> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <i> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <iframe> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <img> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <input> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <ins> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <kbd> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <label> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <legend> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <li> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <main> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <map> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <mark> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <menu> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <meter> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <nav> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <object> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <ol> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <optgroup> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <option> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <output> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <p> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <pre> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <progress> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <q> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <rt> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <ruby> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <s> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <samp> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <section> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <select> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <slot> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <small> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <source> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <span> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <strong> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <sub> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <sup> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <summary> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <table> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <tbody> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <td> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <textarea> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <tfoot> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <th> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <thead> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <time> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <tr> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <track> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <u> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <ul> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <var> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- A <video> element should behave as a pop-up.: FAIL (Chrome: FAIL, Safari: FAIL)
- IDL attribute reflection: FAIL (Chrome: FAIL, Safari: FAIL)
- Popup attribute value should be case insensitive: FAIL (Chrome: FAIL, Safari: FAIL)
- Changing attribute values for pop-up should work: FAIL (Chrome: FAIL, Safari: FAIL)
- Changing attribute values should close open pop-ups: FAIL (Chrome: FAIL, Safari: FAIL)
- Removing a visible popup=auto element from the document should close the pop-up: FAIL (Chrome: FAIL, Safari: FAIL)
- A showing popup=auto does not match :modal: FAIL (Chrome: FAIL, Safari: FAIL)
- Removing a visible popup=hint element from the document should close the pop-up: FAIL (Chrome: FAIL, Safari: FAIL)
- A showing popup=hint does not match :modal: FAIL (Chrome: FAIL, Safari: FAIL)
- Removing a visible popup=manual element from the document should close the pop-up: FAIL (Chrome: FAIL, Safari: FAIL)
- A showing popup=manual does not match :modal: FAIL (Chrome: FAIL, Safari: FAIL)
- Exceptions are thrown even when show/hide are animated: FAIL (Chrome: FAIL, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1789065

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1789066

Pulsebot

Comment 3

•

2 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc8887d72f58 [wpt PR 35652] - Modify the UA stylesheet to allow `<dialog popup>`, a=testonly

Cristina Cozmuta (:CrissCozmuta)

Comment 4

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/cc8887d72f58

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox106: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 106 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

[wpt-sync] Sync PR 35652 - Modify the UA stylesheet to allow `<dialog popup>`

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox106 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Updated

Comment 3

Comment 4