Closed Bug 1788346 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35690 - Use toggle specifier override when converting from integer state back to name.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35690 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35690
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Use toggle specifier override when converting from integer state back to name.

This matches the specification edit made in
https://github.com/tabatkins/css-toggle/commit/0711523aa189346a6ef9a8cbf40b8d8e56f10c0d

The added test fails without this change.

(Support for toggles is behind the CSSToggles flag, which is currently
off.)

Bug: 1250716
Change-Id: I3505e466be1490673aa5fe61751f427c4ed6eb3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3862303
Auto-Submit: David Baron \<dbaron@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040626}

PR 35690 applied with additional changes from upstream: a8b75ba57edfd6c450a3cc14f08168f579c5e205
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 109 subtests

Status Summary

Firefox

OK : 1
FAIL: 109

Chrome

OK : 1
FAIL: 109

Safari

OK : 1
FAIL: 109

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-toggle/toggle-activation.tentative.html [wpt.fyi]
    • finding toggle: wide toggle on previous sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: narrow toggle on previous sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on previous sibling with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on parent with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on parent's prior sibling with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on later sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on child: FAIL (Chrome: FAIL, Safari: FAIL)
    • states used from toggle or toggle specifier as appropriate (integer): FAIL (Chrome: FAIL, Safari: FAIL)
    • states used from toggle or toggle specifier as appropriate (names): FAIL (Chrome: FAIL, Safari: FAIL)
    • group used from toggle or toggle specifier as appropriate: FAIL (Chrome: FAIL, Safari: FAIL)
    • overflow used from toggle or toggle specifier as appropriate: FAIL (Chrome: FAIL, Safari: FAIL)
    • changing with toggle-trigger: set (numbers): FAIL (Chrome: FAIL, Safari: FAIL)
    • changing with toggle-trigger: set (named states): FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle-on" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 sticky" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle-on" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 sticky" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/240e21e75c5e [wpt PR 35690] - Use toggle specifier override when converting from integer state back to name., a=testonly https://hg.mozilla.org/integration/autoland/rev/dcd01f694241 [wpt PR 35690] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/240e21e75c5e
https://hg.mozilla.org/mozilla-central/rev/dcd01f694241

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.