Closed Bug 1788521 Opened 2 years ago Closed 2 years ago

Add a pref to hide Pin Private Window option from Existing users MR onboarding

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Iteration:
106.2 - Sept 5 - Sept 16
Tracking Flags:
Tracking Status
firefox106 --- verified

People

(Reporter: pdahiya, Assigned: nsauermann)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding
48 bytes, text/x-phabricator-request
Details | Review

Scope of this bug is to have a pref flip option 'browser.startup.upgradeDialog.pinPBM.disabled' to hide pin PBM checkbox on pin screen or hide pin private window for existing users MR onboarding.

See https://docs.google.com/document/d/1KoHS9U-nIMeZTWthidWWNoDH9xsOxvRezlmaYp91saw/edit#heading=h.dkcltcp9blnp

We should add additional pref check for Line 1011 and Line 1018 to remove respective element if the pref is true
https://searchfox.org/mozilla-central/rev/9962f512b52f5faba6b5a769b9e89a2a72fb8dbf/browser/components/newtab/lib/OnboardingMessageProvider.jsm#1011

This needs to be clarified if want to remotely hide/show pin private window option in onboarding via Nimbus or we can use ShellService disablePin https://searchfox.org/mozilla-central/rev/9962f512b52f5faba6b5a769b9e89a2a72fb8dbf/browser/components/shell/ShellService.jsm#415 .

Flags: needinfo?(asafko)

Ania clarified in document above for MR onboarding that its acceptable to flip pref to hide pin Private Checkbox and pin Private Browsing screen in code without needing remote config via Nimbus

Flags: needinfo?(asafko)
Iteration: --- → 106.2 - Sept 5 - Sept 16
Priority: -- → P1
Assignee: nobody → nsauermann
Status: NEW → ASSIGNED
Attachment #9294308 - Attachment description: WIP: Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding → Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding
Attachment #9294308 - Attachment description: Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding → WIP: Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding
Attachment #9294308 - Attachment description: WIP: Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding → Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding
Pushed by nsauermann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/320cd127730c
Add a pref to hide Pin Private Window option from Existing users MR onboarding r=pdahiya

https://hg.mozilla.org/mozilla-central/rev/320cd127730c

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

I have verified this enhancement and can confirm that the "Also add Nightly private browsing" option is no longer displayed in the "Pin to taskbar" modal for existing users if the "browser.startup.upgradeDialog.pinPBM.disabled" pref is added to the "about:config" page and set to "true".

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220918214503) installed on Windows 10 x64.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: