1788647 - Name the raptor browsertime profiles better in the generated zip to make them clearer

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P3)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

With Bug 1786400, we will be generating profile zips for all the treeherder runs. When it's a chimera run, it's not very clear which one is the warm and which one is the cold run currently. We should give them better names so it will be easier for our users to understand.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1788647 - Properly split the extra profiler run browsertime.json file for chimera mode r?#perftest

After the extra profile run work, the zip folder names weren't very accurate.
Before this patch, chimera mode was always showing "<test-name>-cold" even
though that wasn't accurate. For example it was showing "cnn-cold" for both
cold and warm chimera test runs.
This patches fixes it by splitting the extra profiler run browsertime.json file
into 2 like we do for the main browsertime.json file.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1788647 - Make the naming of both folder and profile files more expreesive for gecko profile zip files r?#perftest

Previously they were named like "1-geckoProfile-1.json.gz" and that wasn't good
for a few reasons:

• Both numbers were incrementing at the same time, making both numbers
  unnecessary.
• "geckoProfile" word is very redundant since it's used on all the profiles and
  doesn't add any value/context to the users.

Instead this patch converts gecko profile namings to:
<test-name>-<test-type>-<test-run-type>

• <iteration-type>-<iteration>

For example for chimera tests it will show like this:

• cnn-pageload-cold
  • browser-cycle-1
  • browser-cycle-2
• cnn-pageload-warm
  • browser-cycle-1

Depends on D160194

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6317842c10d
Properly split the extra profiler run browsertime.json file for chimera mode r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/e7be7687b12d
Make the naming of both folder and profile files more expreesive for gecko profile zip files r=perftest-reviewers,sparky

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b6317842c10d
https://hg.mozilla.org/mozilla-central/rev/e7be7687b12d