support UtilityActorsName annotation
Categories
(Socorro :: General, enhancement, P2)
Tracking
(Not tracked)
People
(Reporter: gerard-majax, Assigned: willkg)
References
Details
Attachments
(2 files)
In bug 1788596 we will want to use IPC actor names instead of sandboxing kind value to expose on crash reports. It will be a string, comma-separated actor names.
|
Reporter | |
Comment 1•3 years ago
|
||
I dont know if we can / should get rid of the index put in place in bug 1767435 ?
|
Assignee | |
Comment 2•3 years ago
|
||
I looked through the linked bugs and the description, but I don't understand what you're asking.
Is the UtilityProcessSandboxKind annotation changing in some way? Is a new annotation being created?
|
|
Assignee | |
Comment 4•3 years ago
|
||
In order to add support for a new annotation, I need to know what the annotation is and it needs to undergo data review.
|
|
Reporter | |
Comment 5•3 years ago
|
||
(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #4)
In order to add support for a new annotation, I need to know what the annotation is and it needs to undergo data review.
Yes, that will be done in time, my question was what do we do with the existing one that we will remove from CrashAnnotations.yaml ? There will be some records with it for some time on server, but do we need to keep the index?
|
|
Assignee | |
Comment 6•3 years ago
|
||
It depends on how people are using it. If they need to keep searching with it, then we should keep it around until the data has expired. If they don't need it anymore and don't care about past values, then I can remove it.
|
|
Reporter | |
Comment 7•3 years ago
|
||
So the new way to report using the actor names is now landing, what do you need me to do / infos do you need to perform the indexing steps ? We are adding UtilityActorsName as a string in https://hg.mozilla.org/integration/autoland/diff/2ec48e5350225f026d247ee692f53a633fd76765/toolkit/crashreporter/CrashAnnotations.yaml
|
|
Assignee | |
Comment 8•3 years ago
|
||
I missed this somehow. Sorry about that.
First off, the type for the field in CrashAnnotations.yaml is wrong. It's marked as an integer, but it needs to be a string.
Can you fix that as soon as you can?
Typically, because the field is marked as being included in the crash ping, we can't change the type. However, in this case, no one has updated the crash ping schema and picked up this field, so we can still fix it without having to create a whole new field.
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 9•3 years ago
|
||
Fixed with bug 1795888, really sorry about that, I clearly remember switching the type, I dont understand how it could have made it like that and not break any test ...
|
|
Assignee | |
Comment 10•3 years ago
|
||
I verified that it's landed.
Data review was done here: https://bugzilla.mozilla.org/show_bug.cgi?id=1788596#c13
UtilityActorsName is a comma-separated list of names, so we should convert it in the processor.
I'll work on the following:
- convert the value from
"foo,bar,baz"to["foo", "bar", "baz"] - make
UtilityActorsNamesearchable and aggregatable in Super Search - update the crash ping schemas so the data is in
telemetry.crashBigQuery table
Grabbing this and putting it in my queue.
|
|
Reporter | |
Comment 11•3 years ago
|
||
Gentle ping, have you been able to do that?
|
|
Assignee | |
Comment 13•3 years ago
|
||
|
|
Assignee | |
Comment 14•3 years ago
|
||
|
|
Assignee | |
Comment 15•3 years ago
|
||
I'll do a prod deploy later this week.
|
|
Assignee | |
Comment 16•3 years ago
|
||
|
|
Assignee | |
Comment 17•3 years ago
|
||
willkg merged PR #752: "bug 1788681: add FontName and UtilityActorsName to crash ping" in bd40909.
This adds UtilityActorsName to the crash schema, so it'll show up in telemetry.crash.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 18•3 years ago
|
||
I pushed this just now to production in bug #1803661.
Description
•