1788719 - moz-phab <1.1.0 does not use hyphens in user IDs, causing telemetry schema failure

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Connor Sheehan [:sheehan]]

Looking at the moz-phab telemetry dashboard we can see that there have been no pings for version 1.1.0. We made some changes to Glean initialization between 1.0.0 and 1.1.0, and these have likely regressed the sending/collection/etc of telemetry.

Comment 1

[Connor Sheehan [:sheehan]]

Running moz-phab submit with log_level=logging.DEBUG in Glean's initialization function and GLEAN_LOG_PINGS=true in the environment shows that pings are being collected and sent with valid contents to the server. It appears the data is being sent (with 200 codes being seen in the logs), so I wonder if our dashboard is pointed at the wrong data source.

Comment 2

[:glob ✱]

We didn't get any notification of changes to our BQ config, and there's only one schema with a name that appears related to mozphab - the one we're using.

Comment 3

[Connor Sheehan [:sheehan]]

Jan-Erik, our telemetry dashboard doesn't contain any pings from version 1.1.0 of moz-phab. Between 1.0.0 and 1.1.0 we updated Glean. As outlined above I have checked and version 1.1.0 does indeed send pings. Any idea what might be going on here?

Comment 4

[Jan-Erik Rediger [:janerik]]

Hey.

This looks like a combination of a bug in the new Glean version and how moz-phab is setting UUIDs.
Our pipeline expectes hyphenated UUIDs, but Glean fails to properly hyphenate all input.
moz-phab passes in 32-character non-hyphenated strings (e.g. here), leading to a schema failure in the pipeline.

I will have a fix up for Glean later today (and probably a release today or tomorrow).

I looked in our error pipeline and there's about 4000 pings in the past 30 days (query).
If this data is important we could probably backfil it. However we probably can't do much for data coming in from clients that linger on that buggy Glean version, though I talk to the pipeline team to see what's possible.

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: telemetry: make new and existing UUIDs conform to expected Glean schema (Bug 1788719) r?grammar,zeid

Add code to detect and rewrite existing 32-character non-hyphenated
UUIDs to 36-character hyphenated UUIDs. Also generate new UUIDs
with the correct format for new clients.

Some tests were rewritten to conform to the new UUID format. One
test was difficult to mock so it has been rewritten to check the
expected properties of the returned values instead of expecting
an exact match.

Comment 6

[Connor Sheehan [:sheehan]]

The UUID fixing patch will be present in the next moz-phab release (1.2.0).