Closed Bug 1788736 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35715 - [grid] Fix alignment of baseline sharing groups.

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35715 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35715
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[grid] Fix alignment of baseline sharing groups.

Previously we'd make baseline sharing groups both start aligned. This
was incorrect (however correct via. the spec if you read it a certain
way).

Instead the "major" group should be start aligned, and the "minor"
group should be end aligned. See:
https://github.com/w3c/csswg-drafts/issues/7645

Change-Id: Iaa04f89e84116acfb9242a1c9cad0e9219f210f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858306
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1041724}

PR 35715 applied with additional changes from upstream: 4dd9ff44d0a0b225d1a511459055cb6c3b00a8f3
Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/260f35143568 [wpt PR 35715] - [grid] Fix alignment of baseline sharing groups., a=testonly https://hg.mozilla.org/integration/autoland/rev/96962698596e [wpt PR 35715] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.