1788753 - [wpt-sync] Sync PR 35741 - Cancel pending subresource loaders when WebBundle is blocked

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35741 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35741
Details from upstream follow.

Hayato Ito <[e-mail]> wrote:

Cancel pending subresource loaders when WebBundle is blocked

Fix crbug.com/1355162.

If a resource request for a WebBundle is blocked by, for example,
Chrome Extensions or DevTools, the network process won't have a chance
to cancel pending subresource requests associated with the bundle.

As a result, subresource requests will remain pending forever, which
means window's load event is never fired.

This CL makes ResourceFetcher in a renderer cancel every loaders
associated with the bundle if the bundle's loading fails, by
checking WebBundleToken, to make sure subresource requests are surely
canceled.

Bug: 1355162
Change-Id: I0bef5d764131c480413d26656c20aa016a1b1525
Reviewed-on: https://chromium-review.googlesource.com/3861773
WPT-Export-Revision: 9e54005d375eb67b65f5a3ed23a25d9bdc7f222d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=21aef9599a887ec4a54d1eef9d241c5235c31e0b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

ERROR: 1

Chrome

ERROR: 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /web-bundle/subresource-loading/csp-blockes-bundle.https.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: ERROR, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

• /web-bundle/subresource-loading/csp-blockes-bundle.https.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: ERROR, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b842111ec0da
[wpt PR 35741] - Cancel pending subresource loaders when WebBundle is blocked, a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/b842111ec0da