1788763 - [wpt-sync] Sync PR 35748 - [beacon-api] Don't send out beacons if background sync is disabled

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35748 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35748
Details from upstream follow.

Ming-Ying Chung <[e-mail]> wrote:

[beacon-api] Don't send out beacons if background sync is disabled

Context:

1. Spec: Post-unload beacons are not sent if background sync is disabled for a site.
2. Background Sync: the setting available in chrome://settings/content/backgroundSync, which says After you leave a site, it can keep syncing to finish tasks, like uploading photos or sending a chat message.

Bug: 1293679
Change-Id: Idf0d47b7d4e62641c6b2f114f7e8e519fe0644d6
Reviewed-on: https://chromium-review.googlesource.com/3865576
WPT-Export-Revision: 6bf0faec6a149d70748224d184d9b45ed8707507

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 35748 applied with additional changes from upstream: 74938560647321aed597aa158a4bff731edbd759, f1ef84ca14e9e7f18d82544dfa2191ccab027757, 132606abb6068abac3aad510ede995caa37032de, ac84adaa5a4190f4937db37882ba1e3f00511c68, 3fe0bbd42b7f71b3d5e19fe8306e353081b8a85f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cddeaab55b5a01ed17e4985252daf8510aba07a1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

ERROR: 8

Chrome

ERROR: 8

Safari

ERROR: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /pending_beacon/pending_beacon-basic.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-deactivate.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-sendnow.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_beacon-sendondiscard.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_get_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_get_beacon-send.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_post_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending_beacon/pending_post_beacon-sendwithdata.tentative.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfd1bf58c070
[wpt PR 35748] - [beacon-api] Don't send out beacons if background sync is disabled, a=testonly

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/bfd1bf58c070