1788772 - [wpt-sync] Sync PR 35749 - compute pressure: Introducing pressure states

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35749 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35749
Details from upstream follow.

Arnaud Mandy <[e-mail]> wrote:

compute pressure: Introducing pressure states

As described in [1], compute pressure is using pressure states
instead of quantized value of cpu_utilization and bucketing.

This patch is implementing the following:

• Removing the quantization of cpu_utilization, bucketing
  and instead is replacing cpu_utilization value with a pressure
  state.
• A timestamp is retrieved and passed to the webAPI as defined
  in [2]
• This patch allows the PressureObserverManager to register more
  than one observer at a time because the quantization scheme is not
  in use anymore, and all observers observing should receive updates.

[1] https://github.com/WICG/compute-pressure/commit/e3da844ddb2a9bf5d8c86ab561f62bf666ed6d27
[2] https://github.com/WICG/compute-pressure/commit/a10b940a9d50fa3cc526d2b888afe6773d706b20

Bug: 1306803, 1308316
Change-Id: I60dc2a8b789bdc7808e2629d67541cc6755ecbd1

asd

Signed-off-by: Arnaud Mandy \<[e-mail]>
Change-Id: Ic0d81593ad6e7daf04ec671a9aef56644394ed9e

Reviewed-on: https://chromium-review.googlesource.com/3865395
WPT-Export-Revision: 6ecec86767da11428f43d4bac839aab911fd5755

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 35749 applied with additional changes from upstream: 55ad1ef98f411b7212d70cd0c7f783f7b8c8636b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 35749 applied with additional changes from upstream: 00f3dc140f7da496ea0027f36eec0733fa3f9b2c

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c283f13bf88e15139b71ed748c65704b03ca1fc

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 2 subtests

Status Summary

Firefox

OK : 8[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 9[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
PASS : 1
FAIL : 17[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 18[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
TIMEOUT: 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] 3[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview]
ERROR : 2

Chrome

OK : 11
PASS : 7
FAIL : 14

Safari

OK : 9
PASS : 1
FAIL : 18
TIMEOUT: 2
ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_basic.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • An active PressureObserver calls its callback at least once: FAIL (Chrome: PASS, Safari: FAIL)
  • Newly registered observer should get update: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /compute-pressure/compute_pressure_basic_async.tentative.https.window.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Return SecurityError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_detached_iframe.tentative.https.html [wpt.fyi]
  • PressureObserver.observe() on detached frame rejects: FAIL (Chrome: PASS, Safari: FAIL)
  • PressureObserver.disconnect() on detached frame returns: FAIL (Chrome: PASS, Safari: FAIL)
  • Detaching frame while PressureObserver.observe() settles: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive updates: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive updates: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.window.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: OK)
  • Stopped PressureObserver do not receive updates: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_multiple.tentative.https.window.html [wpt.fyi]
  • Three PressureObserver instances receive updates: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_multiple_across_iframes.tentative.https.window.html [wpt.fyi]
  • Three PressureObserver instances, in different iframes, receive updates: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_observe_idempotent.tentative.https.window.html [wpt.fyi]
  • PressureObserver.observe() is idempotent: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_observe_unobserve_failure.tentative.https.window.html [wpt.fyi]
  • PressureObserver.observe() requires a valid source: FAIL (Chrome: PASS, Safari: FAIL)
  • PressureObserver.unobserve() requires a valid source: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_take_records.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Calling takeRecords() before observe(): FAIL (Chrome: PASS, Safari: FAIL)
  • takeRecords() returns empty record after callback invoke: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f0532c5202c
[wpt PR 35749] - compute pressure: Replace quantization with pressure states, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c385086f81ad
[wpt PR 35749] - Update wpt metadata, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5f0532c5202c
https://hg.mozilla.org/mozilla-central/rev/c385086f81ad