1788773 - Update the interface of the network observer to support non-devtools consumers

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P1)

Description

[Julian Descottes [:jdescottes]]

The network observer should no longer emit anything which depends on DevTools network event actors.

The events & objects emitted should as much as possible follow the naming specified in the BiDi network events: https://github.com/w3c/webdriver-bidi/pull/204

I think devtools can still benefit from having more granular network event updates than BiDi, so I don't think the observer should adopt the 3 events design from the BiDi spec (but we can discuss).

This is also the opportunity to start removing the network event actor from the devtools codebase. Doing this cleanup here would be nice, to avoid having a translation layer between the observer and devtools.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Migrate CacheEntry to a JavaScript class

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Migrate Throttle helper classes to a JavaScript class

Depends on D161314

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Use private properties in NetworkObserver.sys.mjs

Depends on D161315

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Use private properties in NetworkResponseListener.sys.mjs

Depends on D161316

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Rename owner to networkObserver in NetworkResponseListener

Depends on D161317

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Remove owner property from NetworkObserver

Depends on D161318

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Remove filters argument from NetworkObserver

Depends on D161319

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Return a promise from CacheEntry.getCacheEntry

Depends on D161320

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Reuse property names from nsICacheEntry in devtools ResponseCache object

Depends on D161687

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Merge NetworkObserver init() in constructor

Depends on D161688

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Use explicit getter and setter methods in NetworkObserver

Depends on D161689

Comment 12

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] Define QueryInterface in class definition instead of constructor for network observer modules

Depends on D161690

Comment 13

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788773 - [devtools] network observer: set default values for properties in class definition

Depends on D161691

Comment 14

[Julian Descottes [:jdescottes]]

This should rather be under devtools/netmonitor

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c35c9e5b1970
[devtools] Migrate CacheEntry to a JavaScript class r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b8cea7ddc798
[devtools] Migrate Throttle helper classes to a JavaScript class r=ochameau
https://hg.mozilla.org/integration/autoland/rev/1c3f707fb4f1
[devtools] Use private properties in NetworkObserver.sys.mjs r=ochameau
https://hg.mozilla.org/integration/autoland/rev/e44aeee85f96
[devtools] Use private properties in NetworkResponseListener.sys.mjs r=ochameau
https://hg.mozilla.org/integration/autoland/rev/649ba7cbda10
[devtools] Rename owner to networkObserver in NetworkResponseListener r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f144a7d387d4
[devtools] Remove owner property from NetworkObserver r=ochameau
https://hg.mozilla.org/integration/autoland/rev/cdc70361444e
[devtools] Remove filters argument from NetworkObserver r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b2c25629b1ac
[devtools] Return a promise from CacheEntry.getCacheEntry r=ochameau
https://hg.mozilla.org/integration/autoland/rev/bc6f0d39eb47
[devtools] Reuse property names from nsICacheEntry in devtools ResponseCache object r=ochameau
https://hg.mozilla.org/integration/autoland/rev/753f2f079c5e
[devtools] Merge NetworkObserver init() in constructor r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fa5e3a63ba67
[devtools] Use explicit getter and setter methods in NetworkObserver r=ochameau
https://hg.mozilla.org/integration/autoland/rev/3977ce574565
[devtools] Define QueryInterface in class definition instead of constructor for network observer modules r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4585c14292c4
[devtools] network observer: set default values for properties in class definition r=ochameau

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c35c9e5b1970
https://hg.mozilla.org/mozilla-central/rev/b8cea7ddc798
https://hg.mozilla.org/mozilla-central/rev/1c3f707fb4f1
https://hg.mozilla.org/mozilla-central/rev/e44aeee85f96
https://hg.mozilla.org/mozilla-central/rev/649ba7cbda10
https://hg.mozilla.org/mozilla-central/rev/f144a7d387d4
https://hg.mozilla.org/mozilla-central/rev/cdc70361444e
https://hg.mozilla.org/mozilla-central/rev/b2c25629b1ac
https://hg.mozilla.org/mozilla-central/rev/bc6f0d39eb47
https://hg.mozilla.org/mozilla-central/rev/753f2f079c5e
https://hg.mozilla.org/mozilla-central/rev/fa5e3a63ba67
https://hg.mozilla.org/mozilla-central/rev/3977ce574565
https://hg.mozilla.org/mozilla-central/rev/4585c14292c4