Closed Bug 1788779 Opened 2 years ago Closed 2 years ago

Add JitCode API for Gecko Profiler

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox106 --- wontfix
firefox107 --- fixed

People

(Reporter: denispal, Assigned: denispal)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(3 files)

Add a JitCode API for the Gecko Profiler so it can surface data about jitted functions, along with their debug info.

Blocks: sm-jits, sm-meta
Component: JavaScript Engine → JavaScript Engine: JIT
Attachment #9292849 - Attachment description: Bug 1788779: Add API for the Gecko Profiler to access JitCode address ranges and debug info r=iain → Bug 1788779: Add API for the Gecko Profiler to access JitCode address ranges and debug info r=iain!,mstange
Pushed by dpalmeiro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1aac72154bbd
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4119d765347e
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/f8a7091761965259a2be5bb4aafe8f60c72c3352

Push with failures

Failure log bustage

Failure log SM wasi

/builds/worker/checkouts/gecko/js/src/jit/CacheIR.cpp:12106:26: error: '%s' directive argument is null [-Werror=format-overflow=]
/builds/worker/fetches/sysroot-wasm32-wasi/include/sys/mman.h:2:2: error: "WASI lacks a true mmap; to enable minimal mmap emulation, compile with -D_WASI_EMULATED_MMAN and link with -lwasi-emulated-mman"
Flags: needinfo?(dpalmeiro)
Pushed by dpalmeiro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b1e05f3830c
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/17488b8527ed
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain
Regressions: 1791573
Pushed by dpalmeiro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29a719a41bb9
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4e02d349f5ea
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: needinfo?(dpalmeiro)

(In reply to Pulsebot from comment #8)

Pushed by dpalmeiro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29a719a41bb9
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4e02d349f5ea
Add API for the Gecko Profiler to access JitCode address ranges and debug
info r=iain

== Change summary for alert #35519 (as of Mon, 26 Sep 2022 09:37:10 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
2% youtube ContentfulSpeedIndex linux1804-64-shippable-qr cold fission webrender 1,341.50 -> 1,374.17
2% youtube loadtime linux1804-64-shippable-qr cold fission webrender 1,336.75 -> 1,366.71

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35519

No longer blocks: sm-meta, sm-jits
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: