1788779 - Add JitCode API for Gecko Profiler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Denis Palmeiro [:denispal]]

Add a JitCode API for the Gecko Profiler so it can surface data about jitted functions, along with their debug info.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1788779: Enable PerfSpewer compilation by default r=iain

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: Bug 1788779: Add API for the Gecko Profiler to access JitCode address ranges and debug info r=iain!,mstange

Depends on D156306

Comment 3

[Denis Palmeiro [:denispal]]

Attachment: Bug 1788779: Append JIT information to the gecko profile r=mstange

Depends on D156307

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aac72154bbd
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4119d765347e
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/f8a7091761965259a2be5bb4aafe8f60c72c3352

Push with failures

Failure log bustage

Failure log SM wasi

/builds/worker/checkouts/gecko/js/src/jit/CacheIR.cpp:12106:26: error: '%s' directive argument is null [-Werror=format-overflow=]

/builds/worker/fetches/sysroot-wasm32-wasi/include/sys/mman.h:2:2: error: "WASI lacks a true mmap; to enable minimal mmap emulation, compile with -D_WASI_EMULATED_MMAN and link with -lwasi-emulated-mman"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b1e05f3830c
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/17488b8527ed
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain

Comment 7

[Andreea Pavel [:apavel]]

Backed out for SM bustage at PerfSpewer.cpp
Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2d5f5979479b19e009548aa52cc59bd6d36c6280&selectedTaskRun=euIKe88aQ8-_ewJYQBl7Ug.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=390943088&repo=autoland&lineNumber=29821
Backout: https://hg.mozilla.org/integration/autoland/rev/013ef018da29a76b2429d5332be4592e044b6750

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29a719a41bb9
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4e02d349f5ea
Add API for the Gecko Profiler to access JitCode address ranges and debug info  r=iain

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/29a719a41bb9
https://hg.mozilla.org/mozilla-central/rev/4e02d349f5ea

Comment 10

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #8)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29a719a41bb9
Enable PerfSpewer compilation by default r=iain
https://hg.mozilla.org/integration/autoland/rev/4e02d349f5ea
Add API for the Gecko Profiler to access JitCode address ranges and debug
info r=iain

== Change summary for alert #35519 (as of Mon, 26 Sep 2022 09:37:10 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	youtube ContentfulSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,341.50 -> 1,374.17
2%	youtube loadtime	linux1804-64-shippable-qr	cold fission webrender	1,336.75 -> 1,366.71

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35519