1788785 - ::first-letter font-size seems to be ignored when there is also a ::before, breaking a dropcap effect

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Thomas Wisniewski [:twisniewski]]

Attachment: testcase.html

See the attached test-case. The first-letter's size seems to be being ignored in Firefox, but not in Chrome or Safari.

This is currently breaking the drop-cap effect at Reuters on Firefox, overlapping the text.

Comment 1

[Jonathan Kew [:jfkthame]]

It's not specifically the use of ::before that is the root of the problem here, but rather that the ::before content has position: absolute, which removes it from the flow and should allow ::first-letter to "capture" the following letter L. (Otherwise, ::first-letter would apply to the first letter of the ::before content itself.)

Example using only position: absolute to reproduce the failure of ::first-letter:

data:text/html,<style>p::first-letter{font-size:2em;color:red}</style><p><span style="position:absolute;top:100px">foo</span>bar

Here, Safari and Chrome apply the ::first-letter styling to the "b", but in Firefox no content gets the ::first-letter style.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1788785 - Skip placeholders for first-letter-finding code. r=jfkthame

Tests incoming (if this doesn't cause any existing test to pass).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28008334e7f0
Skip placeholders for first-letter-finding code. r=jfkthame

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35768 for changes under testing/web-platform/tests

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/28008334e7f0

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot