178880 - Bug Creation Date doesn't get displayed in long list

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Frank Wein [:mcsmurf]]

When you make a query and then click on the long list-Button, there is no Bug
Creation Date (in Bugzilla it is for example "Opened: 2002-10-20 02:42")
displayed (it should be above the <hr>-line and Comment 0 in the bug, on the
right side of the page).

Comment 1

[Frank Wein [:mcsmurf]]

-->myself, want to create my own patch, then you can review it :-)

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch 1

This patch should fix it, can someone take a look at it?

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

This should be the right patch now, can someone take a look at it?

Comment 4

[Terry Weissman]

Sorry, but whoever signed me up to review this patch: I do not consider 
myself sufficiently up-to-date on the codebase, nor do I have time to be 
doing Bugzilla stuff.  I don't know the procedure for removing my name 
from that and assigning someone else (see, I *told* you I wasn't up-to-
date), but someone should do that.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 105852 [details] [diff] [review]
Patch 2

moving request to "whoever's available"

Comment 6

[Jacob Steenhagen]

Comment on attachment 105852 [details] [diff] [review]
Patch 2

>Index: mozilla/webtools/bugzilla/attachment.cgi
>-#!/usr/bonsaitools/bin/perl -wT
>+#!F:/perl/bin/perl.exe -wT

This is bad :)


>Index: mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl

Why did you include the bug.creation_ts twice?	On my test installation (pretty
much using the strait-from-cvs params) this makes "Bug Creation Date" apear
twice in a row.

For future reference of anyone trying to apply this patch, you should "patch
-p3" and it does have CR's in it (although patch seems to deal with these just
fine)

Comment 7

[Frank Wein [:mcsmurf]]

*eek*,hm, I'll do it again.

Comment 8

[Frank Wein [:mcsmurf]]

Attachment: Patch 3

This should fix it

Comment 9

[Jacob Steenhagen]

Comment on attachment 107803 [details] [diff] [review]
Patch 3

I know it's not your fault that we went and changed some things in recent CVS,
but this doesn't quite work with what's out there now.

>+    bugs.remaining_time,
>+	date_format(creation_ts,'%Y-%m-%d %H:%i')

In order to be compatible with formats from other databases (mainly Sybase in
this case), the format here should be '%Y.%m.%d %H:%i'.  Also, date_format
should be aligned with bugs.remaining_time.  It looks like you used <Tab> to do
your indentation.  That actually isn't allowed according the the Bugzilla
styleguide (Tabs are interpited differently by different text editors).   The
Bugzilla tests check to make sure that the code doesn't have any tabs in it,
but I don't know that those still run on win32.

>+        <b>Opened: [% bug.creation_ts %]</b>

This should be [% bug.creation_ts FILTER time %].  This filter will make sure
the time is in the correct format for display and append the timezone as
defined by the site.

These changes were made as part of bug 67077.

Comment 10

[Frank Wein [:mcsmurf]]

Hmpf, next time I'll have to update my tree more often.

Comment 11

[Frank Wein [:mcsmurf]]

Attachment: Patch 3b

well, nothing to say :-/; this should fix it

Comment 12

[Frank Wein [:mcsmurf]]

Attachment: Patch 3c

Comment 13

[Frank Wein [:mcsmurf]]

Attachment: Patch 3d

Comment 14

[Jacob Steenhagen]

Comment on attachment 107825 [details] [diff] [review]
Patch 3d

This is the one...

Comment 15

[Jacob Steenhagen]

Checking in long_list.cgi;
/cvsroot/mozilla/webtools/bugzilla/long_list.cgi,v  <--  long_list.cgi
new revision: 1.33; previous revision: 1.32
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.8; previous revision: 1.7
done

Comment 16

[GavinS]

*** Bug 122919 has been marked as a duplicate of this bug. ***