1788840 - HTMLEditor::HandleCSSIndentAroundRanges should not use moved variable

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Makoto Kato [:m_kato]]

I guess I overlook Bug 1774704's review.

https://searchfox.org/mozilla-central/rev/2c8fa11af2d6e795c99ebe395d39390fde47df85/editor/libeditor/HTMLEditSubActionHandler.cpp#4398-4404

    const EditorDOMPoint pointToInsertDivElement =
        pointToPutCaret.IsSet()
            ? std::move(pointToPutCaret)
            : aRanges.GetFirstRangeStartPoint<EditorDOMPoint>();

So pointToPutCaret is moved, so it may become nothing value. But we re-use pointToPutCaret at next.

    if (NS_WARN_IF(!pointToPutCaret.IsSet())) {
      return NS_ERROR_FAILURE;
    }

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, indeed, it should check pointToInsertDivElement.IsSet() instead.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1788840 - Make `HTMLEditor::HandleCSSIndentAroundRanges` stop referring moved `EditorDOMPoint` r=m_kato!

Unfortunately, the result is really different from the other browsers.
E.g., when execCommand("indent") at <div>abc<br>{}<br></div>, Gecko inserts
a <div> and set its margin-left. However, Chrome splits parent <div>
element and wrap the <div> which contains the caret in new <blockquote>.
Therefore, this does not contain new WPT.

Depends on D157404

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343bf04a54ba
Make `HTMLEditor::HandleCSSIndentAroundRanges` stop referring moved `EditorDOMPoint` r=m_kato

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/343bf04a54ba