Closed
Bug 1788882
Opened 2 years ago
Closed 2 years ago
Check module status on entry to JS::ModuleLink API
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
Currently we assert the module status is as expected in at the start of js::ModuleLink. This means means it is not checked in release builds and any unexpected status isn't detected until later.
We should unconditionally check and throw an error at the API boundary. This already happens for JS::ModuleEvaluate.
|
Assignee | |
Comment 1•2 years ago
|
||
Checks the module status unconditionally and throws an error if it is not as
expected.
This now includes the unexpected status in the error to help debugging and bug
reported.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7567091b43b Check module status on entry to JS::ModuleLink API r=yulia
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•