1788882 - Check module status on entry to JS::ModuleLink API

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

Currently we assert the module status is as expected in at the start of js::ModuleLink. This means means it is not checked in release builds and any unexpected status isn't detected until later.

We should unconditionally check and throw an error at the API boundary. This already happens for JS::ModuleEvaluate.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1788882 - Check module status on entry to JS::ModuleLink API r?yulia

Checks the module status unconditionally and throws an error if it is not as
expected.

This now includes the unexpected status in the error to help debugging and bug
reported.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7567091b43b
Check module status on entry to JS::ModuleLink API r=yulia

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f7567091b43b