Closed Bug 1788892 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35767 - Revert "[beacon-api] Don't send out beacons if background sync is disabled"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox106 fixed)

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35767 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35767
Details from upstream follow.

Monica Basta <msalama@chromium.org> wrote:

Revert "[beacon-api] Don't send out beacons if background sync is disabled"

This reverts commit c6eaa2c93b9f3f4452b0437f221feeefbcc07370.

Reason for revert: blink_wpt_tests are failing on multiple bots on different platforms due to virtual/pending-beacon/wpt_internal/pending_beacon/pending_beacon-sendondiscard-backgroundsync.window.html and wpt_internal/pending_beacon/pending_beacon-sendondiscard-backgroundsync.window.html.

Original change's description:

[beacon-api] Don't send out beacons if background sync is disabled

Context:

  1. Spec: Post-unload beacons are not sent if background sync is disabled for a site.
  2. Background Sync: the setting available in chrome://settings/content/backgroundSync, which says After you leave a site, it can keep syncing to finish tasks, like uploading photos or sending a chat message.

Bug: 1293679
Change-Id: Idf0d47b7d4e62641c6b2f114f7e8e519fe0644d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865576
Reviewed-by: Rakina Zata Amni \<rakina@chromium.org>
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Commit-Queue: Ming-Ying Chung \<mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1042466}

Bug: 1293679
Change-Id: I9cc0f5ed22ef653d21fd2fc362bfc603665d155f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/3870853
WPT-Export-Revision: 1ceab4a1651267e2e1209680ec98a0cd3e16f775

PR 35767 applied with additional changes from upstream: 74938560647321aed597aa158a4bff731edbd759, f1ef84ca14e9e7f18d82544dfa2191ccab027757, 132606abb6068abac3aad510ede995caa37032de, ac84adaa5a4190f4937db37882ba1e3f00511c68, 3fe0bbd42b7f71b3d5e19fe8306e353081b8a85f, 50f3316b00c646af003e088d97db9a3315f2c736

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

ERROR: 8

Chrome

ERROR: 8

Safari

ERROR: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/754b3f3bb816 [wpt PR 35767] - Revert "[beacon-api] Don't send out beacons if background sync is disabled", a=testonly

https://hg.mozilla.org/mozilla-central/rev/754b3f3bb816

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.